Skip to content

Conversation

@NL908
Copy link
Contributor

@NL908 NL908 commented Jul 21, 2025

Fix tincture quality rounding issue:
https://www.reddit.com/r/pathofexile/comments/1foqn64/increased_tincture_effect_doesnt_round_the_way/
Also, this is what I got in-game vs pob (rip -3 divs of alt)
image
image
image

Description of the problem being solved:

As the post on Reddit says, "The game calculates the increased effect and rounds it first". Thus, a 35% increase effect and a +21% quality should result in 1.35 * 1.25 = 1.6875 ≈ 1.68. Therefore, a 19% ele pen should result in 19% * 1.68 = 31.92% ≈ 31%, instead of 19% * 1.6875 = 32.0625% ≈ 32%

Steps taken to verify a working solution:

Link to a build that showcases this PR:

https://pobb.in/XWWVPpewJTrs

Before screenshot:

image

After screenshot:

image

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Jul 21, 2025
@LocalIdentity LocalIdentity merged commit bf3de46 into PathOfBuildingCommunity:dev Jul 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants