Skip to content

Conversation

@Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Jul 15, 2025

Fixes #3951.

Description of the problem being solved:

As far as I know there was no way to search for Item names in Modparser, so I added a condition to "ItemCondition" in ModStore.

Steps taken to verify a working solution:

  • Having Iron Mass in main hand gives the skeletons the weapon as before, as well as off hand not giving the weapon.
  • Removed the DUMMY mod so config option only shows up when Iron Mass is in main hand now.
  • If you have another mod that uses the same config, it won't apply the triple damage to skeletons when toggled because we require "The Iron Mass, Gladius" to be in the main hand slot.
  • "20% more damage if you have hit with your main hand weapon recently" will have the config appear with Iron Mass in offhand, and properly not give the triple damage.

Link to a build that showcases this PR:

https://pobb.in/SzAJuJj2lVhI

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't usually love hardcoding item names into the code, this one is already there and really does only make sense when it has the other mod anyway

@Wires77 Wires77 added the bug: behaviour Behavioral differences label Jul 18, 2025
@Wires77 Wires77 merged commit ac5a7b5 into PathOfBuildingCommunity:dev Jul 18, 2025
@Blitz54 Blitz54 deleted the iron-mass-fix branch July 18, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iron Mass Skeleton Triple damage applies while iron mass is in the off hand.

2 participants