Skip to content

Conversation

@Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Jul 4, 2025

Fixes #
image

Description of the problem being solved:

Maven Memory Game and other boss skills in the Config menu would break Vile Bastion. We were setting the actual Block Chance to 0, so Vile Bastion and any other nodes/skills that use block chance like Mystic Bulwark.

Steps taken to verify a working solution:

  • Skills with CannotBeBlocked do not override output.BlockChance, they do so farther down in the calcs.
  • output.BlockChance is still set to 0 from CannotBlockAttacks or CannotBlockSpells, so things like The Eternal Apple still function.
  • Calcs page still shows block chance on the left, and Unmitigated % shows 100% as expected.

Link to a build that showcases this PR:

https://pobb.in/I6azipBrk7sI

Before Screenshot

image
image

After screenshot:

image
image
image

@LocalIdentity LocalIdentity merged commit af700b4 into PathOfBuildingCommunity:dev Jul 8, 2025
2 checks passed
@LocalIdentity LocalIdentity changed the title Fix Maven Memory Game "CannotBeBlocked" Fix Maven Memory Game skill breaking Vile Bastion from working Jul 8, 2025
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Jul 8, 2025
@Blitz54 Blitz54 deleted the fix-maven-cannot-block-flag branch July 8, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants