Skip to content

Conversation

@n1tr0xs
Copy link
Contributor

@n1tr0xs n1tr0xs commented Jun 23, 2025

Fixes #8704.

Description of the problem being solved:

The 100% blocking effect was handled incorrectly. (said in issue)
I don't have idea, is it possible to achive such value for block effect in game, but issue is issue.

Steps taken to verify a working solution:

  • Checked EHP for various block effect (0%, 50%, 95%, 100%)

Link to a build that showcases this PR:

Sample for block effect - EHP testing

eNqtW1tz4rgSfp75FS6qztOpCdeQZIvMFgm5VSUTDmRmzj5NCVuANrJE2XIS9tdvS7KNYZCRsOchA1Z_fZO6pW6LwZ8fIfXecBQTzi4b7ZNWw8PM5wFhi8vG95fbL-eNP79-HoyRWD7PrxJC5cjXz58G6rNH8RumgGt4AkULLH5knLq_gNMKMbHEnD2hv3l0x4PLxjfOcMObIRYQkX3zKYrjbyjEl42pD-CGh2Ifs-B68zwlXKII-QJHj1LqMBH8iQcwKqIERkNE2JT7r1jcRTxZKaXeCH7XNA9P4-fJS0ElwooqgUWfBmOK1jiaCiS8GP5cNobgGLTAIxTCX-CGaAKsWietTqNZirhKolg4wKYrjIOcsn1iJBxH-GY-x74gb_g6IuJ6iZhfkGHCudI-JVSQFSU4Kmh1akLc_8bcSPrCBaKj8XTLLb1yai4OK_2TiOUVBS9a85aIhwUjAjtBxpzEnDlbsAUwej6hFMLLinaCYxy9IUF2lDHy5uGMMAf_PCGGrnls4XtJOcYRxKxwAkyxzyHMXWU4Ih_JHNtTOtmRAly1Oc6Om6ktnTPj4xSaQHazo5zyhFpSik3C6RipRvjDguqBCSteb1yoXeeQbiqUb-7HOWX3_KTTuWh3zlpnZx1jxhsv1zHxEX1CHyRMQsiVL-gVb-T1S9bKYikYJAQTtHtmgt6SCLujrjkNjkAtEY-NsHNzRBN2DweBoe8nsK2vc0ivNHgs_Aa7qf-HpH1gvl1EfmeRSqeFTbhfCphAnMitfkaxJWIjIo22zcbaOiBqgVkqb21nziPG_vIO_DtBAtvl1s3OXe5WSWvlVkm4x62nlgAHJ0mgwUknF2UgRzfdMBwt1tMlwTRwo84Uu0YrixQo3VxEW7l7W5zTiilCHV3yE0WB3UbhqtMbiotJud0vd5cmt1uYGI6JAAiw7YF4HPG_5ZGbusGGUciTyHLCNbGVAdmGouuLCQ4S324DyyuHKwp10o4ZF4dhoCilbtihEMh_HfFgYe02JcUJsa3gNFmtIIvI9WDLQO6WcJ4mhRPKl74F9TMsZquYlhurvYANtbWA_KhgL2UHYm-L3O4djNmQW4vIJ_QJ0kUI24Cqj6GQ3-QD4-RACWVVDylCy7pszN9B86XscMRu1HAs2hyFjKpEmP2ztua_RW4l4IYFcMSCULCWsYvYJ-aFhJBK43iEBPKC9Bj9A0UEMdFR7ZcYo8hfPsLU3yJKZ5AJLhvFp-qbatncEipwNIJnUqhUbJdjO5v0QVO1nuSnh3DFI-HhD_nfGEVifdmYIxpjTaieAJ9YEKYKZchHlDa86ZK_D4M3KemFcxpnIA-tVpgFWzxeIow9lGUXXyqhjJdfvBDFoPVaL9dYWlPoXD0EygzGQQE495yfd7vSdllfoWg93CZkBPQSIKvQQOv0096Y5iTFfhp8nzyqD5-WQqziP5rN9_f3kxUSSz7HH7BDnfg8bK4ABAp_iV8JpV8k2-YQ_l0thuqfYtTMOA100yxu6m8ySCMCOutJbkpDldelJ-SHb1zgWI7Jh9mXwVSKimE2I3GHw_hqDYF1K08UO52H1JWSeoqFXiVFTNbNC_AcJVQ-_1-CKJEz2yo-fdSNR8ajMC-tgBXMrMz_muPLeiVdP3x81CNDKlJmUlw2zXo6U4U8EmzWmbZJfrxG1Fc2Dx7YKhEeU13JkMT-r1kyn8sWI4gQkeqa3tze3ly_PPy4SeOkCFEz8osl4Ux21vT_m2w2xWon9-JkFuuPl40fBL8rRUZYIEIhdn1OKVrFOF-oSunUAgq4Em6KCoq0rDe5n9eGwMzp5gNHEFcLOAL6EcFGvfLxA0ppgfJ4KPOKiZvsBZoZ6dPGNUSlPr4aPKWarWYusv9pNEcOlmAhIyFqlJyOHvCEkMsWoo7MiS9TcvmUy0WuqUr8kpfYxvlOj0pmHqq5amKgB81g3TQ1odPREq-qNq3Rq3rUDB9hHxlt14NmcF4RcQZuMnHJqUo4feNMLXIImiGh8lhjnNkbinMSM8NnscRRuvmYOD1BjspISgMnIrNEmMO4QFHiK9WfMXhIjpmhugdhsEGOlWSirbrc4NAijZmVrmeNiawMqo-4Rv-lB-aSKUirRYP79WiJE7KC2WB_OlwSJCr_Dt84CXTRZAiXHbKyhAHniupsVCVYnc1uaVid4y0czV6N852OmuHfBZEnkT1c9AHIiokMqmocZGxV4_BCmC-SCB_NYLJ7EtlgJ-VnkLyc2QvORssyR1rlHM1B12JHw1WpeDRa5f8RnmOwoHQDyGlK4kMkbATOECWxYclKqbU_kWysc-Klt8K9ljpz1AGevqQoywGa5AAj2MvvS06Ldpzydsc9RlS-Yea0GsPfXsZUYSabtskKsSBj97zvjL6ZB0vvcREDT1XKj2RvuKoPGQ7XexiZ9Ro0s6pOFfmyzkpbE1MRyVr-H87Dv1TZKT-lBWc3LTLhxD0iMG-RWm-ZHEn4_6ytMngQUGamFa_8nBe8ZgZJjPUr2J8YrThTiEKZmnIpIUsL2LSypxwqWsCMZ1DtS5t0FXpHoc4CP8kh3VxolgO0GK_tALniMMPecLaOY0Q93WPwTl0YYCp28R0HvNp3vO4RVnrTd7TaFd07hlEF81MenRp47DeoX4NB_RoMOorHPoMqr85uDR7p1GWNy3q7x7BBikr-2BNs_coadJw5VBbZrcv_pzUshnYN4dGuQY-e40qoK8V0qkZkrwYHuu8ZtaXYblX7OxVD2E2BYO3pPkOVNajPFlU47A_s08oc-nVNa7uuHOO-NKv7sVd5Lk_rWVQuxg_DhGJRQybs1pBQuhWDslcR367H_0fvlM6LtueMOOYUVdGrp1VzdU3T0qsrudR2rj66hHLATQhbOE3h_tTUqWcOatsp6ij4esfZ5Or86nt8TYeN08qKVN_i-q7JoGry-F3goJk2e_RdmwgFeKq6Uz-xvLgV6xaWajGpGwqczckibTbpL2m7SeHzJ54ggmL52lPdpNjuFxVvKvhJLHj4xIN4c7Phv-1W6z9eqLuL8udYzMee4N5MvurxkHr77gWqz_ZZ09rQmPjF8pVNObstkr944gn0ij1Fyuee7vh584iHnnobhQNPdWvTGRpT5OMlpwGOUqOx7CKmP8bKLmectVoHAFs34jJY9xAqv3-X3cXIkJ1Or31IYuHnXBns9ACmeMkxxxw0DZ4coZ-UdQRM9Vg3iPOemT7Mf6Amf5SFIxxM1d0PnjAxxXReuFxzamGjs2Py2RvL_no-6bYo94mQa2zXpecXfYuJcNJQrqxdMV2bVWIrZepz1WKHyYp_uwFllJDedeaUThAr6nZ2SLdsN8wA_fbF-YUZE5MFoc9z9WIOlFRvF22V3L6Y7bTy89f3uaxWu1fmxSWkM4MTB8082-vXHOrb18-D5u6veP8FAR4zmg==

Before screenshot:

b_0_b_50_b_95_b_100 (2)

After screenshot:

a_0_a_50_a_95_a_100

@n1tr0xs n1tr0xs changed the title Fixed block effect calculation. Fixed EHP - block effect calculation. Jun 23, 2025
@n1tr0xs n1tr0xs changed the title Fixed EHP - block effect calculation. Fixed EHP based on block effect calculation Jun 23, 2025
@LocalIdentity LocalIdentity merged commit a871a88 into PathOfBuildingCommunity:dev Jun 26, 2025
2 checks passed
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Jun 26, 2025
LocalIdentity pushed a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Aug 29, 2025
LocalIdentity added a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Aug 29, 2025
Copy from PathOfBuildingCommunity/PathOfBuilding#8711

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat pushed a commit to Tonkat/PathOfBuilding-PoE2 that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect calculation for 100% damage taken from blocked hits

2 participants