Fix Wretched Defiler missing skill types#8707
Closed
leotianlizhan wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Closed
Fix Wretched Defiler missing skill types#8707leotianlizhan wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
leotianlizhan wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Wretched Defilers do not work with many skill gems due to missing skill types
Contributor
|
What you did will work and it's what i've been using as a stopgap for a while. See referenced issues/PRs here: #4628 I've got a better solution for the skillTypes issue specifically here if you'd like to test it out Main thing with that patch is that i'm really not sure if it accidentally allows for supports/mods that should not apply bringing back #4628 in some form. Additionally many effects (support/active) have stats that explicitly shouldn't apply to minions and i'm not sure how to weave that into current handling. |
Contributor
|
Superseded by #8707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wretched Defilers do not work with many skill gems due to missing skill types
Fixes # .
Description of the problem being solved:
Wretched Defiler's skill doesn't work with gems like Controlled Destruction and Spell Echo for some reason, even though Spell Echo clearly works in game. I looked at the
spectre.luafile and compared the skill to another spectre's skill that do work with those support gems (Forged Frostbearer), and found it's missing[SkillType.Damage] = true, [SkillType.Multicastable] = true,. Added those toskillTypesand it worked (see screenshots below)I'm not familiar with how the export works, I assume
#addSkillTypes Damage Multicastableis all I need to fix this during the next export script run? I didn't run it either. Please advise.Steps taken to verify a working solution:
[SkillType.Damage] = true, [SkillType.Multicastable] = true,toskillTypesinData/skills/spectre.luaLink to a build that showcases this PR:
Before screenshot:
After screenshot: