Add support for various "Infamous" (Mercenary exclusive) item modifiers #8698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debilitated so far only cause 10% less damage (presumably because it was only applied to players), but should also apply 20% less movement speed Also added the "globalEffect" / "debuff" tag in case of future interactions
This enables "Your are debilitated", "Nearby enemies are debilitated", "minions are debilitated" etc. No effect on ModCache as no such mod exists on uniques or tree (only "Infamous" mod atm)
NOTE: This doesn't correctly work when putting the item on an AG because actor = "player" is necessary. actor = "enemy" did also not work and is less safe. Not specifying an actor would make it based on monster fortification stacks in some cases. "player" is the best solution until we have actor = "self"
"Skills used by your Traps and Mines Chain 2 additional times" - Added "skills used by your traps and mines" preFlag - Added "chain " as modName (extra space to avoid match with "chaining") - Added "(%d+) additional times?" to formList
This in combination with previous commit enables mods like: "Projectiles chain 2 additional times" Also included modCache to check it doesn't break any existing mods
Previous preFlag was limited to "have/deal/gain" etc. which did not work with e.g. "chain" modName. So now "Socketed gems chain 1 additional time" works. Changing the lua pattern from "[hgd][ae][via][enl] " to "([hgd]?[ae]?[via]?[enl]?%s?)" would probably work in a lot of places , but I didn't want to do that much testing. It doesn't break any other "socketed gems xyz" mods for now.
added 2 commits
June 26, 2025 17:56
LocalIdentity
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for:
Also:
Steps taken to verify a working solution:
ModCachecheck and some additional testingLimitations:
Link to a build that showcases this PR:
https://pobb.in/OWX-JW52C4u0
After screenshot: