Skip to content

Fix Dual Strike of Ambidexterity and Cleave of Rage #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix Dual Strike of Ambidexterity and Cleave of Rage #8304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7b5790
Fix Dual Strike of Ambidexterity and Cleave of Rage
Regisle Sep 18, 2024
bf6629e
fix whitespace
Regisle Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Modules/CalcActiveSkill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,11 @@ function calcs.buildActiveSkillModList(env, activeSkill)
if not skillTypes[SkillType.MainHandOnly] and not skillFlags.forceMainHand then
local weapon2Flags, weapon2Info = getWeaponFlags(env, activeSkill.actor.weaponData2, weaponTypes)
if weapon2Flags then
if skillFlags.attack or skillFlags.dotFromAttack then
if skillTypes[SkillType.DualWieldRequiresDifferentTypes] and (activeSkill.actor.weaponData1.type == activeSkill.actor.weaponData2.type) then
-- Skill requires a different compatible off hand weapon to main hand weapon
skillFlags.disable = true
activeSkill.disableReason = activeSkill.disableReason or "Weapon Types Need to be Different"
elseif skillFlags.attack or skillFlags.dotFromAttack then
activeSkill.weapon2Flags = weapon2Flags
skillFlags.weapon2Attack = true
end
Expand Down