Fix ES from Tricksters Escape Artist when using Oath of the Maji#7018
Merged
LocalIdentity merged 1 commit intodevfrom Dec 12, 2023
Merged
Fix ES from Tricksters Escape Artist when using Oath of the Maji#7018LocalIdentity merged 1 commit intodevfrom
LocalIdentity merged 1 commit intodevfrom
Conversation
The calculation for Escape Artist use the final doubled value after Maji has affected the armour
Wires77
reviewed
Dec 12, 2023
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
Did not even realize this section was here. Would it make sense to just combine this with some of the logic around line 544?
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Dec 12, 2023
* upstream-dev: (31 commits) Release 2.37.0 (PathOfBuildingCommunity#7019) Add support for new Uniques + fix parsing for changed mod names (PathOfBuildingCommunity#7016) Fix ES from Tricksters Escape Artist when using Oath of the Maji (PathOfBuildingCommunity#7018) Fix Necromancer Offering charm not working (PathOfBuildingCommunity#7014) Update Query mods (PathOfBuildingCommunity#7011) Fix projectile count being 1 higher on all skills (PathOfBuildingCommunity#7006) Fix Herald of Agony quality not working (PathOfBuildingCommunity#7017) Fix Pyroclast Mine Aura Effect scaling Maximum Added Flat Damage (PathOfBuildingCommunity#7005) Fix Ascendant nodes counting towards allocated passive skill total (PathOfBuildingCommunity#7002) Change Manastorm config option to not overrun options box (PathOfBuildingCommunity#7008) Release 2.36.1 Release 2.36.1 (PathOfBuildingCommunity#6996) Fix pathing and mastery nodes (PathOfBuildingCommunity#6989) Export from game files Fix Crash when opening Timeless Jewel search (PathOfBuildingCommunity#6995) Fix negative bypass being ignored (PathOfBuildingCommunity#6992) Release 2.36.0 Release 2.36.0 (PathOfBuildingCommunity#6988) Add support for Tincture Implicits Fix ES Bypass not overriding sources of negative bypass (PathOfBuildingCommunity#6965) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calculation for Escape Artist use the final doubled value after Maji has affected the armour
Fixes #7009