Skip to content

Fix allocation issue on tree conversion #6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix allocation issue on tree conversion #6364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Classes/PassiveSpec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ function PassiveSpecClass:Init(treeVersion, convert)
for id, node in pairs(self.nodes) do
-- if the node is allocated and between the old and new tree has the same ID but does not share the same name, add to list of nodes to be ignored
if convert and previousTreeNodes[id] and self.build.spec.allocNodes[id] and node.name ~= previousTreeNodes[id].name then
--Commented out for now as it was breaking nodes when upgrading trees
--self.ignoredNodes[id] = previousTreeNodes[id]
self.ignoredNodes[id] = previousTreeNodes[id]
end
for _, otherId in ipairs(node.linkedId) do
t_insert(node.linked, self.nodes[otherId])
Expand Down Expand Up @@ -894,6 +893,8 @@ function PassiveSpecClass:BuildAllDependsAndPaths()
if self.ignoredNodes[id] and self.allocNodes[id] then
self.nodes[id].alloc = false
self.allocNodes[id] = nil
-- remove once processed to avoid allocation issue after convert
self.ignoredNodes[id] = nil
else
if node.type == "Mastery" and self.masterySelections[id] then
local effect = self.tree.masteryEffects[self.masterySelections[id]]
Expand Down