Skip to content

Combustion fix when a non-damaging skill precedes a damaging skill #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Combustion fix when a non-damaging skill precedes a damaging skill #6344

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d23508
Fix a crash relating to accessing gemdata for granted supports
Lilylicious Aug 13, 2023
6404134
Properly exclude non-damaging skills from combustion ignited by effect
Lilylicious Aug 15, 2023
cab4df8
Merge branch 'dev' into combustionFix
Lilylicious Aug 15, 2023
8dcd483
Skilltype damage or attack
Lilylicious Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Modules/CalcPerform.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,7 +2247,7 @@ function calcs.perform(env, avoidCache, fullDPSSkipEHP)
modDB:NewMod("WitherEffectStack", "MAX", effect)
end
--Handle combustion
if activeSkill.activeEffect.grantedEffect.name ~= "Arcanist Brand" and not appliedCombustion then
if (activeSkill.skillTypes[SkillType.Damage] or activeSkill.skillTypes[SkillType.Attack]) and not appliedCombustion then
for _, support in ipairs(activeSkill.supportList) do
if support.grantedEffect.name == "Combustion" then
if not activeSkill.skillModList:Flag(activeSkill.skillCfg, "CannotIgnite") then
Expand Down