Force skill groups to display as active based on main skill #6317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilylicious
force-pushed
the
forceActiveSocketGroup
branch
from
b2122d2 to
d58d7af
Compare
LocalIdentity
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2976
Description of the problem being solved:
Path of Building treats the currently selected Main Skill as active regardless of the Enabled config in the skill group itself. This is to ensure that it can be calculated properly for the build sidebar. However, it also leads to some unintuitive behaviour for the end user, notably that any auras in the skill group are treated as enabled even though the group itself is disabled.
It's probably desireable that the main skill is treated as active, but the user needs feedback that this is the case. This PR changes the display of the main skill's skill tab group to not be coloured, and state that it's forced active, without actually changing the state of the group. This means that changing main skill back off the disabled skill will once again show it as disabled.
Link to a build that showcases this PR:
https://pobb.in/fXSPGxmEI6jO
Before screenshot:
Note the 50% mana reservation, despite the skill group (gloves, number 2) being listed as (Disabled) (Active)
After screenshot: