Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to only compare stats for same jewel types. #6314

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

michelrtm
Copy link
Contributor

Fixes #6275 .

Description of the problem being solved:

When hovering on non-restricted (like timeless jewels) and non-cluster jewels in POB the tooltip that compares the benefits and drawbacks of adding the jewel to the build compares them to cluster jewels as well as per the image below:
image

Steps taken to verify a working solution:

  • Tested enabling and disabling new option
  • Tested with hovering on existing jewels on the build with new option enabled and disabled
  • Tested with adding new jewel to the build with the option enabled and disabled:
    image
    Tooltip with option enabled.

image
Tooltip with option disabled.

Link to a build that showcases this PR:

https://pobb.in/fX8QA_1MH4ve

Before screenshot:

image
Cluster jewels present in tooltip.

After screenshot:

image
New option added to the options screen.

image
Cluster jewels no longer present in toolip.

@michelrtm
Copy link
Contributor Author

I realized I forgot Abyss Jewels in the tests above, here is a new POB link which includes Abyss Jewels:
https://pobb.in/sf95K0iZx9Bh

And some tests that I ran:
image
Option disabled, Abyss Jewels also show on tooltip.

image
Option enabled, only jewels of the same type and subtype included in comparison.

image
Adding Abyss Jewels only compares with existing abyss jewels.

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Aug 11, 2023
@LocalIdentity LocalIdentity changed the title feat(6275): Added option to only compare stats for same jewel types. Add option to only compare stats for same jewel types. Aug 13, 2023
@justjuangui
Copy link
Contributor

@michelrtm Hi, are you going to resolve branch conflict?

@Glorithan
Copy link

Would love to see this get finished. Is there someone currently working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An option for "DO NOT COMPARE WITH CLUSTER JEWELS"
4 participants