Skip to content

Conversation

@mortentc
Copy link
Contributor

@mortentc mortentc commented May 4, 2023

Fixes #6189 .

Description of the problem being solved:

Spell suppression chance from dagger mastery did not get applied to elemental ailment avoidance when ancestral vision was equipped.
Also minimizes dependence on the dagger mod flag, hopefully avoiding future bugs where one forgets to include the flags. Do note however, if one includes the flags in weaponsCfg as part of a calculation, the mastery will be counted twice.

Steps taken to verify a working solution:

  • Allocating the relevant mastery and Ancestral Vision
  • Equipping 0, 1 and 2 daggers.
  • Allocating Spell Supression Effect and Spell Supression is Lucky, which used to include the dagger mod flag in their calculation.
  • Acrobatics does not interfere with Ancestral Vision

Link to a build that showcases this PR:

eNqtW-1z4jYT_3z8FR5mnpnnmRLiF8xLJmmHBHJHm9zlIMm1n24UW4AaYVFbTsJ1-r8_K8kGQ5FjY9qZxKD97ZtWq92N7_yXtwU1XnAYERZc1K2mWTdw4DGfBLOL-sP99Um3_svPtfM7xOdfppcxoWLl59qHc_lsUPyCKeDsusFROMP8MWXlfAdWSxTwOWbBLfqThR-Zf1H_zAJcN55Q4BOefvIoiqLPaIEv6mMUzHBYN1Dk4cC_yi4QXyx4cxQij-PwRkjux5zdMh_WeRgDpwUiwYR5z5h_DFm8BMXqxgvBr4pmdHv3ZXyf0YoEWa3Aqg_ndxStcDjhiBsR_Lio98E5aIYHaAE_gRuiMbBqW81ey-6Ybrdjmp1u_TQXfBmHET-Mw2SJsb8GWU23paO8C_FwOsUeJy_4KiT8ao4CbyPPMpumVsoh9Lcx5WRJidiVtXptVwf5tEeCqSO-ZxzRwd1kTdtzm07P6rQ7ptPr2VY-jvE1TivhG-HzSwq-PUCKwI5mAeH4APAdIxELskCn3bRt9x367eDptJtmR48RCv5bjmV2mrZptl3HcUHD93y4BbWaXbPb7bYdLewqphRSQxaldf4YRzh8QZxsK6ilv2KLJxJs71VBa25RgK5YVCAiBOUdDiHv8FKACfYYpKqyMkoib8gUF6csZUcCKKvNYXYMJ0XpSjM-TKExnKtilBMW04KUfJMTbW3CHuC3TfLIOSt_bRFqD_0o4AWEArssoeVYevVemDih75srM8bw011GvNM0e61Wy-p2OvoLa76KiIfoLXoji3gBF8Q9esYbeVavpY-_2ZwHkG60WH0CviYhPgB2xah_CGyOWHQATpywIp6A-sA7E8SjwCt2bh-CUKbfbFmR5-kpHsNxEoXME8VFIRshyakscusrWTMcJAJXxQy6wdibf4TKb4w4LpaDMxdbN9ezgriQZwXhPs_q-W8jSrhJAPe7yW5aeaCSjhoGOJytJnOCqV-OOlXsCi0LJEvh5yy6kL-3xZWKmSy0pEu-odAvdqWU1ekFRdlca7_jLkWe9ZSlvRhuMdS5gPDxTgFu6lsJ9qdoJGg5WD9csDgsuOOKuNBepxeFKoLH2I-9YhfTJYVecLfrcHPUonQfRG8w58h7HjB_VthHUkh5xCReLiFViE3fwbXNvIsOKm2SqVhOilB_gZAtdHLFlVhcwIa6sID1NV9cyg6kuC3ini5hzIa8sIh1d34LSWEByV729rcsc1toNweaq0KdkiTc7t30x4q9guZzMbaJylFDPbPpXrWqhDj4sSrMf4u8kIBh4MehOAuFZewi9om5JwvIl1E0QBwZflIDP6KQoIDbcqAUYRR68xvY-mtE6RNkgIt69lvxaQdopXt7firnZuJptFiykBv4Tfy6QyFfXdSniEZYEcpvgE_ESSA7ZUg3lNaNyZy99v0XYcU9YzRKQQZaLnHgb_G4DzE2kIw5kXOFEtJG8SE7Yhv50rAFijjcVipOgfHfbbvrOg3bdC33n7oRMNAGHNVtOw3XbLm9Rs9x3Uar1-t0G22n03MbTq_bthoO_Oo1Wq7puI2ERavl2A1AtuGn024BpW3bnQZ0792G223Bo9tzOmYDlsxe3eCgeGaSCGWyGhIKRW1pw4fzh_GNfPgw53wZnZ2evr6-NpeIz9kUv8HV1fTY4nQJILD-JHomlJ4Itqd9-O9yNrocvHZ__3X0Mvjy8vxj0fk2fEPfw94fj1PvV-_jzIb69m3xm3sSdr5_7V8-XN1Z868XF1LwaSr5XI0aI6VG8km6SegpvVA3CMcLpfapAp1mUPABtkLGhdgr8fCZcSzXxJfph_OJ0D8yIgiVj3gRXa7ghF-LAmZnOJJstqCeYK7CNYtJB6U-nqKYiu-_xogSEXtm9tsbNdcNWLhYN2jACmJP3ESK4_1qKeKhf3OjVvqUJ8yEuDQQVcAlChnE35wEZZN4vELUU_4YBcsYXChHvgsSed-f4ulUTG9BBA_lUHp4fT28uh89DpMDm4XIbf4exIsnMZVUvzdpdYJl3WBE8VOkHi_qjwS_SkUGmCNCIYl4jFK0jPD6KEmlEwso4HK4SSpo89Jx3X5eGwI9p-EbDuHkz6Di9EKCtXqt199RSgkU1ahIcDpuYnSqZ6TKnSvIEqpa1nhKTqz1XMTsWGuOWMzBQs5EVCs5WX3HE1yELZw6MiWeuBvyt1wEuaLK8YvnwbXirXL2Oyna9DzkLFrHQC3qwWrWq0MnqzlelbNsrVfVqh4-wB7S2q4W9eB1A8YCcJOOy5oqh9PnZEoOh6ZPqKivtDs7pHhNomf4hc9xmFyGOk63kKNSktyDE5KnmOuPcYYix1dyJqTxkFjTQ9XQQ2ODWMvJRFtjAI1DszR6Vqp91iayPKiqtbX-Syr3nC1IelON-9VqjhPS_lxjf7Kcc0hk_u2_MOKr9k1zXHbI8hIGlBHV2chWtDqb3Sa1OsdrqPeet_dblS6CTbKoRz9wIgqRakzEmarGQRytahzGu3XEBjvOryBk-hrgKQY_5-avNU3O9vI4GMAdx3e3dqNNQU5Sq3ePQSlmKpPvtbS0eio-kyl9XggrkncYwVX0KafYKcZpPTb4hBEVf9dltBrDf_01opKdjEco8Adi3FnRUDEtjZfALNXsy75qdbOlu1zPT9M-Qja-orJPuvIJhy7ARzP5askPxhZ_XNRPbKfT7LU6LdOynZbbUQtJ39NOeh0o_AYE_B_KuEmFC8LfgUPPNpuu01tzkEqMoN-Lkj5MPKdtWBxh9WfJbxgtWSC_DghV_ZEgTHoj2SSOEdTBqzPj4fPo68OwJkZnxigEf0EtF_Da8AdbrDg2BtKkWtJ1nRm2WUuayzPj8gT-r0l7xvivM6Nt16A-psQjYtWqOeZ_DBJ4IUbgVuMjZU-IGqL8FpNWAzxGnrGhytbaT47BmSF5GWxqIEqNdCZryMxvyFrZEH1fbQBhCk2wAUWWOJfwQW2UbH6hlZOv-Bih-AlNZ9OtZ5rCPAr7XYp0hHMq3LntV3uvX_tiV3kIKj4ScWvVHklIfIIC41f8imnthiyg9PXBeOGxjPvM2t9S-BnI_uen_7onlvk_4aIBfuNYiKiBktBg4DASXys3iqf0ikzcpjwDDo2YmN_Q1Ta1zJMZR6ZFq4G44cL-wV5ABiSh8ShmWEdy8I77RNeui91syJ5PKONy2nH39DC-EUMw1ZNDaL2ItJwOQsxUER1ACTGsDcR6D3LJIA0Z_adVFImQVIMYt4TMS0z5Lt4ugZf3uOEcYKUxeUXLXdGtQxhVMD_hYR-Bx36D2kcwqH0Eg_bykEsjHxjsDu8UM5kMjMw8LxVWVIl9HrHKROe-8HaO4FL7EJdWDdhPGLIYr-SPPae1XVkDuzSHyiKdY_nfPUIwWEc4X9YR9GiVjIRj5Si76olsHcGB5S-do-Vop6r9dsUjXE4Bf2WosU2VGFTFSRUO-w-2W5lD-1jbah0rx5QPzep-bFXeS_c4QVXG-P4ippgfIRM6R0goTsVD2aqIt47j_4NvytJB2yqNOKSKKtPc7PGqWzVXH2lbWsdKLu1jMTq4ByuBG5NgVmrX96cm-zh7cLSb4hgdY-swm8o6v_odf6Riw62sSPUrrl02GVRNHv8WqIZGE8zlHFbOQOWLHSyYkln6MpaH54z6OExY4wAvVsm_b0tf1ehkX3veRy8mlOnbFSnIeQeThlhKb9vvy0jfskwxbj4keTWVUSpna1mD8oHrPyymgHYnH7D9MmxGUDoDT1x-frr7bzb_DxfaTy4=

Before screenshot:

image
image

After screenshot:

image
image

@mortentc mortentc changed the title Dagger suppression Fix Suppression from dagger mastery not applying to ancestral vision May 4, 2023
@LocalIdentity LocalIdentity merged commit 6a7f31d into PathOfBuildingCommunity:dev May 4, 2023
@mortentc mortentc deleted the dagger_suppression branch May 4, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dagger mastery and Ancestral Vision interaction

2 participants