Skip to content

Fix Ailments breakdown showing crit damage while you have Res Technique #6164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix Ailments breakdown showing crit damage while you have Res Technique #6164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3466,7 +3466,7 @@ function calcs.offence(env, actor, activeSkill)
if isAttack then
t_insert(breakdownDPS, pass.label..":")
end
if sourceHitDmg == sourceCritDmg then
if sourceHitDmg == sourceCritDmg or output.CritChance == 0 then
t_insert(breakdownDPS, "Total damage:")
t_insert(breakdownDPS, s_format("%.1f ^8(source damage)",sourceHitDmg))
if sourceMult > 1 then
Expand Down Expand Up @@ -3575,7 +3575,7 @@ function calcs.offence(env, actor, activeSkill)
end
end
if globalBreakdown then
if sourceHitDmg == sourceCritDmg then
if sourceHitDmg == sourceCritDmg or output.CritChance == 0 then
globalBreakdown.BleedDPS = {
s_format(colorCodes.CUSTOM.."NOTE: Calculation uses new Weighted Avg Ailment formula"),
s_format(""),
Expand Down Expand Up @@ -4040,7 +4040,7 @@ function calcs.offence(env, actor, activeSkill)
output.IgniteTotalMax = totalMax
end
if globalBreakdown then
if sourceHitDmg == sourceCritDmg then
if sourceHitDmg == sourceCritDmg or output.CritChance == 0 then
globalBreakdown.IgniteDPS = {
s_format(colorCodes.CUSTOM.."NOTE: Calculation uses new Weighted Avg Ailment formula"),
s_format(""),
Expand Down