Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for totems explode on death #6158

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Apr 29, 2023

This moved totem explode to its own type of explosion, this is modeled on Add support for on-kill explosions #5696

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Apr 29, 2023
@Regisle
Copy link
Member Author

Regisle commented Apr 29, 2023

there is a totem life config, but its currently used by "totems take damage before you", not sure if they should be moved over to use that as well or not

@Wires77
Copy link
Member

Wires77 commented Apr 29, 2023

Using an existing totem life config makes more sense to me than corpse life if we have it.

@Regisle
Copy link
Member Author

Regisle commented Apr 30, 2023

Using an existing totem life config makes more sense to me than corpse life if we have it.

forgot that the config option is for total totem life (across all totems) not the life of a single totem and thus cant be reused for this

@Wires77
Copy link
Member

Wires77 commented Apr 30, 2023

Using an existing totem life config makes more sense to me than corpse life if we have it.

forgot that the config option is for total totem life (across all totems) not the life of a single totem and thus cant be reused for this

Would it make sense to change that config option to a per-totem value and just multiply that by the maximum number of totems for the "take damage before you" mod?

@Regisle
Copy link
Member Author

Regisle commented Apr 30, 2023

Would it make sense to change that config option to a per-totem value and just multiply that by the maximum number of totems for the "take damage before you" mod?

no because different totems can have different amounts of life and different amounts of maximum totems, this also requires the main skill to be a totem to have the stat for "maximum number of totems"

I could add a specific totem life config option for this, but it would be its own thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants