Skip to content

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Apr 28, 2023

Description of the problem being solved:

Display is borked for Betrayal uniques based on some of the crucible mod changes.

Checking if the crucibleModLines is also not empty as well as nil for the crafted/crucible line-by-line in ItemsTab. I went through the build for the older PR adding this all in and it looks fine.

Seems to happen with Betrayal Uniques that are not weapons/shield. Diadem and Vivinsect and so on

Build

eNrtXWlz2ziT_jz6FShXzVamItkEDx1eZ97yHe_aiV_ZyezulymKhCROKFJDUnY8U_nv2w3wFsHDUk3tvpOkKrFFdANo9PkAoE7-8XXlkicWhI7vvTugh8oBYZ7l2463eHfw6fFqMD74x8-9k3szWn6cn20cF5_83PvhhP9MXPbEXKA7IJEZLFj0OeGk_Qqc1qYXLZnv3Zm_-cG1b787-OB77IDMTM92ouQ3yzXD8IO5Yu8O7szA3NgsOCBmaDHPPs8e_cdmsWCBZ24ioFhCOytiwS12f7qJ_DvfhjZRsAF-K9PxHnzrC4uuA3-z5qN7ctizaHNzd_9x-pgbm-PlxwZT--Hk3jVfWPAQmREJ4Z93B6cgIXPBLswV_AvcTHcDrFQ6OpzodGgYmgL_HRzVEp9tgjB6HYeHNWN2SkQPdVnD-4BdzufMipwndh440fnS9KysO0NG17Xt3caNnLXr4EolUzkcajKS91vcqaLIGj_6kele3D-kbTXFOKR0rNGRrhpjtZ7Oj1I6aQ-_ONHyzAWRvqKXm4XnRCxPSLVDVVPGqqoo6lhX6zrdJtbo-FDTJ1Sb6Op4OKwjvved0Pd2EMwrBn2-cV2w9zylVKpTFrLgyYyc4iCl7c_91czxSovQThx3pmee-2GLpcaW9ywAXxJ1Inhglg_up2sfHSlvnTlr37LTPGKCrqN53TwuH9q268z4dQOagpNt1_LB37gtW0aZszMMuRX8nm9IdSm_C_Y1bTZSa_jlG46lNnHjZXPQRvJOn3y00Obpcq9x-f4-57J1cPEjTRsadbHqfvkSOpbp3plfndVmBa7_0fzCvByboVwBF8vIA38jo9XHMtIrJ2Ddqc59134F1dL0w-5kaF7Zgo9qYr11jG1vPKudzX7yAu56cymCnD0STMGSMCeZuawlRdZFbI9tArnoasG8uL-XdtO5ZcxaXkMONzUj1s77ZnY5rhUrtm0lVmxYIVY5-yJBByEhYbWQ6KFRR9RRTJceCxYvD0uHuXa31snAzs11CyeJYs5TtxJ3sbtOGpMn7SiSX8zAbhdKuo7pyQzzPpbWG3vcvJ1iMshbgcBmpYRakZcE_m9YELjdyE6Dlb_J4thYqV9y0bzVFJIAIUqhKbM3ViEiGVLKMxequrYTgGG5bieK0ygyrS8Xvr1gnTrpTvGwWa_BV-Cqt6XDAAcZtpPLVAbDFq0_gsq2slyMhe07yFq37iCN7u17KZG0nwtG6A6TyZq37iIts-_AKazA2fMa_c7PlenSxYGiqlWFxBsW6za5VfnPMPIlgjBht9aQyWSJo3QoAfP-eGnNv9C8VQeXnr0J0BRa91GmqOrm0VmBwwzDCzMyiR3nvp_NwDG9SOXAUMjMwFrewtJfma47Awfw7iD_Kf-Ng0lXjhux4AI-w05xYGWONFn0kyOOjuFPN6u1H0TENcPo1LL8jRe9N8PluwPTsswZNfSRSW17aFqT0XCi2dbI1uz5TLUmc6bMKJtBaoOkU2a6K1i28wPCviLDezOIXt4dzE03ZKLJeYKJCf6TMfA1jNmQanPNmBgaVZg-M9SJpUN9rWg2pWOdqbYYL2cH0wkjx-MVPHhD1z0gD0v_-dR-wgk_-r4bpj2a6zXz7ORXzuMxYIyY3CYwJKAs-BrgL3k478bmgl_BmCGaCjsKUcyeDwOADHpER0afjkZD44BEwDSHKao0hgsFE-T_w8mn6S3_4YdlFK3D46Oj5-fnw7UZLf05-wpx79DyV0drIIKRDcIvjusOkO3RKfw5W1ye4f-c0VHC6UTAh6FQoiOcAV9VnCL-8MGPWIjP8MPkl5MHZB2CtgTRNVuFZy9guFeYl5SwjlhG2PqBRUIL8zQJjmmzublx8fN_bkzXwfVW8p_eCuzV84NVWm4BK1gyjC-C4-PLGmV6ensrnpy6UcwMu0vWT6xTPCDi2Jkeiznhj-ema_E5n9x4601EPI7KrpzQ-nW2mc8RXIUuooADx5dXV5fnjzefL2M7zJPwFfjV26xmiB6K_zNv-cB4NkDCzSwUP747-OywZz6QCxaZjgu-wfJd11yHLNVAPuh4Bi7Q1XDjraBuS6DYal5ZAzmny68sAINZQCJpBQ6Tjit93jAo0SEmmei3ZNwQ4pQzEknMOfoMngRLJMUBZTkXxHil08GHNbTg8UxX2nP8tEESEaotWJ0zdyx0-fVLjkouWtXIxbIgWlgvNesdp2JyHhwzljEQD-XEAr6VUcdPa6TKoWOpVMVTOfkFs0zp3MVDOXFaV_keiEnGJW1Vw-mD73ElB6M5dVxMm6Qre-mytImc4cdoyYI4hsg43YGPSprUGk7gzDaR3IxzLWpkxVEeiYTwmZxUIBmSOeCzGk9UqO4lAs23kbMSVbHUkdWRihRaKr84Ia9ZgrjmlIhfPK0RQlJ2S-YfP64xEu5_T598xxZFmcRcSs3qHAbkEbuz4QXm7mzKpefuHK8gFfsiXe_4qZz8U-RgJlLBRSRArZigUe3GAW1rNw7TciKR0U7rUwjuvy7YnIGgax1Y2qZmfaONdwFBLqpZ25as-LCqDSGbWidewpVXzrQzR6GgMe5ep8OiSQMjiEXva7KddpxSOOA9VGq4V-u7uzHc2l_YaZ5-FJqefYEw5o4TRRR0swZmycg-VqWr2ZKWuZ4cJYUELxgxtY-r7YcowCrwD99f_fe7gwGlw8OhPlH0sWZoEyoexCWPGpc5kPNdOCD5gGtM0i02_C_goKnqoa6ruDWuKboA009uIqh74hIMf04qsE3IxAbjL8xc-x7_OFccYdO4MOIV4hQq_ujlmExPp5e9DzAHbNCDxY8GZgR2yGzyiBgLEfG2J4LXMdENI_75zAyT3VaoUY8J7Z0H5jxi9jHBafTuAzZ3vh4TPJVS88sD1F4tfomLvmOiKr24uIXBD-Bvj8t0yn4_JiOlB-m561gOPqW9B8uHdSGQOKygeiHPS-aRF39DeFgjYNZOQMT69v6MzEV4DIEFZmaxvgtO-duflpjQtz8D01uwY-XQ-Pb2DTUGqvETiXyyEipO0IP3oPHGcmYu-0aNH4njWQEDAdmEY3NpL2mjgfYjEfk6cuIDyj09deEDKH9CcrpY8Gj3xAgIHFWY1_dQrU5xTISPDOrqQ0Ooa7wPW9NCa2yhN7ZINnaOUGsy_XoSMBL2EQ-moGufPtz889Nl73T2EoabsHf5h796iWBem2ABSxylOjZWFImOKYeKoaq9GK46JqBJRD1UD5XiR9qhkv_ofBOAgUU9UVnDmqRPtO1ByBWtoGrDgqrBeG07JLqCizlUSLJFEK87firq2rBX0CVVSXTJdF2S5ee9P2NRHtOS8inKgBrKTz8iDd9LIVjN8r7A_zhfGMmONmVc1LIKQ7_QcUcuWsVY2nPJSGNKnEVmJ2LBC810ZWAUG23JFd1yvarSRmX-S02mpsWwscWo2uzEEKtM7XHJyJTZM9e0We8a_nXA7m6ZudiAMZ3H3qZa5a8H8Feq8LSnK_mFuXb9GSxLAlKQqYm4UnHRQenouHY98-25QeUMJNaGLRIs2AkoFPfCZA0RC939C_lPx3WZXTQ3XUEeCudXHup7E6IqeXz2yXtIDmBsD89-YKdCIvcCfyUcsCEY-ns1z4gTkoCt_Cdg5Mwh1MDvsKzOHEwh9yzn8rNtzpDcO-jziOkR07YddPow30d-PjVHwdc-ZAjZzv0AFi_fesoW8O_HYBb-7cyjpsVYbkB6XV505m5glSHLAxVfbVxYhr8k11Hyuc2oaH-lhGUFNeC3gvMcD4xhwdiwTCT8JAATNRaqPmulHlUCM4oC-_Bxend627v2XRuyLKg4Vy0dCzWqJmZh2tQPOOKCWVIp9NABnYjAI_KradowZyCqIk3E9mMTVWIZFsVyd3p9c967YOHaj8jpV0Z89AaM3DJ_bQZ2j9NxYUDeo0myj7wbHhbzjreagVK4YF8jhj3mk0j0oGN8ShWCG-rbWejNCrw2Sg08-AaH81f5iirJjaQh7Jr5oN-QWZDrl4D13juL5cwPPMgyzPm8ZTw7ywnRUIsq95aOt7LxOGFLMo3nJXhm8oy1EEQLiBSib4walIhOtqKdqhSjHcevKkLdm_F2OlTOpOLRoaPnbEqJZNJdvixBe4_DoyELjyLq1QWyZydaEt9zX0i8KVdsFO4jCn6PUG0i1LjSPi7df4N6P_z305njiZ9C8tkJUcWuEFUIyHvmrtLaSh2OpbWVOtb0Xowyi5bxL5KmHRLJgsfXtaIPK5dEmtBj0HzmLaKl7HnO59XbkpgvpFM2iSdUMtUBr2IyAiFidNUCbZn7G6-FrXw3hbIpVKnxpBoUCMwvJmhPosJXwLB35TBYswsTL05JvPoA_uY9u9aiSqn2rT0oIn7Em1lxFHgMHOxXBGdw8lPTCWFF147NghA8InehRUUabfv8xgpnPKCaKHBizS5T8GYUWxiTYhKDQFM2XrEDiwN770T_4nqUAk1qPCGlUqnwbsQz5JBRCvMUM4YL5j6xMnREaTvsSC0xlevnoKylw0L-oebRntenIjmw5y1mvq9iUlR6KCkfNqsVqNQ9MIvMcBV7tBRJPfe9cLNi6Bf9YB2ybZhHb5kDqQZqfyEFMsOI8IMeWw6-ZGSSyiZHded48HFIbAaG9UY3BgYVRjccDkbjn_KVc9n-bub5mdrpVKFDDIjuS58_x-jiQYU4eyGnrotwc5AMiBEwVAgmaQoWcqD-e9rTmPakdp4IhVba-Z0fpz6QMSw2bhJDrgMzXPc--w6oncXW8LBo63QbOVYPte2Phtv4Mp20cxJGsftWMQzyLol36KulzYVLlx_dzYWXFKvt633jWzH8bbU24HGA59fhYVI1iPNsqK484Nnkf_DoXxGSLj4hSxNSnbeGomxviqQ-qa9VU0G8rCEz-rq0swqyzN4riVIfE-PtGWgQ9lSjmADmyMmD8wcrrEIfpPst2VUSlRQBu497E-qHUTgkl1_Xrm-zPnc86GjRMwsIwAmEQ4CsslCcp3N_ZQ9G6x74TL7JpSacZYW_3UpqEo56e24rH0YkZWQ0Msp2Hyo5ffetZd9aJ49mgdBmiVCtpROv3ha8-813IVz2rsFW3bILVra9st7OURttHbXot9U-c3EvRC1bVNHr4qkWkhxrwfQ8Nuuil0O_nrhigdBwusclpK9L37Wbatyy_sdnuSEJdDzyFsoHZ1Xw4bETy3PVlEEpWUuvr6RZI4JBcSIZwz_VJlvlNcrceuj80yofvPHvG_BSGKF6bzV4cuNFkCs6C0QxCk9zkcgolGw8YzRjOK7Qo0g749oolylrO9GLIJvkzI2EfSE_E_ETI04CIZmE1fWfve21kXGLPSAvV6sTa0QY4lF9R9e6ucJJs5tT9ulP5ZWtnnpVGSyOd-E3ATcox7TZqveBWQEi5Yj6nTuBhRtV4tRsfIznmNCJ2ssfpN2G9gzDGKYV8hmLAvPFzPnj1F6x4Im9ZeJrC_43hecaWxYMvakxz2SwUXnjJ6xsjvf8OjTPTK09TUEi2aybZVKYdyPnxtZQ4zJya77EjgKDQpX8fGsTxt4i8VzydvGxxyx-VTXl5yy3qotXcJ20W-g2q9t6SZvWsc3itVixmmWqXZsm0TWtQhVwpVc6ijr8Ko-w6qUNSA5NCrwIyo40aOH1rK2Y1jf6w_6oP-5P-lTpU9qnap9q3wpEolgr5lAxwJO-n4dczucwAhDsS64PvU-NPh326ahPx3066atKX4We1b6q9VW9qptS2VfdQwkJNsgVw0QBZnvlQnZGGN6qJ0lED4sY2BiPWhUToYJL7tEsBcHdvcJDxJj45VCUMShsEGXQ2yZE2I1nYb1L1wbFtJbkzIzwUmLh_Fj1Kcb0YE22zZI7LdZAk9t6yR0OayAqmEO5CK2kHQ3oWJTrsXIWKs1KkvGAxifSavxHPmdt4FLjYVIuw0YuTT4oZTWSsBoO6KiwWiUnlTIYNzGo8WIpk0mnUUjWValkgmuqFsHbLX-Y8chpb2KEqRHHuXBqD9w_5mirtfjNmG5h0llxNk_8a8hZOt4cHF0Ug-W8g8LwqvUWxIRnU7KyQhIf5-CCBYZjiywOtysI37CHePiEGZmfLwuK1Rod0q3jdK-eiFGy2eFAVdpbER1KyduYDx1JyVvbDR0XeWh0oBmtDIZOZJRtLEVVWvUrIabFFdUHdNjWNFS1pUW0LDrVwhFhkWsszZC8MQbj4q5MTEqS18nEey0pI61sbpP9KKla0n9FOJI9mdn_gSL571oCt4AU65o0Ywu0WbK0WbS0Wba0BdTaLF21WbpqC41slq7aLF21Wbpqs3TVZumqzdJVm6WrNktXa5au1ixdrYXBN8Hh-C6QWIOrEJ7PzpPj4bW13if4LyJTPKUux2W-4yKy1uJqI4Ybz_cGyZXJLPbUoCRLPDjxQezqJ7txEuiFb0OK1waR-IU-tU35G4xatUzfE1Tb-l8VLpGvRJP4G2TeQtBV4AnNm2N2yDF_vLF0oL1wRvitUQ2XnELP7TCTShgjt5HfDivR-hK4pIm9jDM_tf8be4YlhKTwVzO5yya7PFm-8Mbp-bXLaXZuhhrlQzMcI2GmtSSfPMsPgs0ah8od6-XvG2e9xpSR8-I3IgYqP8qHr4IVgsFX5XLBi_2xlNt5LS9xGyGbXf5eQhPS0g6RaN2NuhNk0bobbXdMQ64RTSBOI9rRzNrYBQdpZj_cA0JSjfXg3ZbSQbimAFa1p1yNAwk36hUDGtrAG3Wg_0TEBXI5ppLDhQTsK3G8lSBQkaLoiisRnyLBtnPuYJpSRLMd0NG-I625o72YJ9WbO9qDgVKZGTXjKy2YDxuZ72akdNRt9BIgM2dKUvvRG22HVlvkDkgL7W6OOYo3Glh8Hj5ZICJiFmmzY-55wKuTRecJZH3mSSu67OITqohk3ZbJ066_n5j4Dhd9h4v-v8NFk9ZAjxSiAc1Nfjl1499jFamCbM4dDy8HPUNt4z-TT4HXe3Bc8NyEv4CrBrzBG0nJNaSsgBb4NX_1EF4R4-8nxAsIoTjunJ2fwTGLoWQfTvPlIFY9uXo3fuOz2FM44gcN03dl5ZGAORO3Kra5Ttk8rozzo6w_fJmhFtXzlR_OpEpRkFhRw3pkDfgl_JSu8Aho8ycbcmX6uHQLMZe0vp0UTpdvRZfxt2RjHkv7OHpsX4rxiHivpU2s-HZMro-Mg5ECO11YjNPz4UkLyEmQNt7miKsGfEUKoYXTFFvnwAubWO254l5uaW9ni3O_sDEXZzLkDSRgP2V3YtJpY_TFOYsTsIUuuzDlOr9vpsWDGV25l07a4qGI0m2nWAUQ6tiEjZvxb4bKYNzqyrhsSNVs8WqUsQPbXKVFxa2nghvLNuO2HZqMpWSXXVyXbLy2K-OqS7nySwVB2X3mQCMJR0Ny4GDrwEPB_bbgZhRu85l8m3PG-FYmuG5PziNXYOVANa3qMpqMxahe-wJZPOBvZiox3TFp_p7w_o0S3lJKhq91l7_hMP9iw5MH148IRK7V_ezT9Ja_l5-_tv3aBbsLD_gjfPt-ukYyAtENoRnJsInkzPfBtfEX3KHD5Eg6MTr0ecYgdynRqx3oeX5EtFfMkjw8m-ty1_prGO0w_ZiHugce1RMa7mFCwz1M6FU8qiZEuyhXlXZqe5CIuq_ZdNE3fK0Ji3aSR4WxDXcegdqZQ0agvq5LbV_yN_agDHQP5kH3MA69oybsy8Wou1qkvgcBdo8Ze3Ox2q7zV3c04W4DsF-S9wPtoIMit9iFQ7VhGztzGO5rWem-fEx31dxdjvrOa2nsR6m6TF68aTIj0F_rCbU9OBRtR6PUd6Sn-5H_qyNlZ6XVO1O8JovaUarGrr56T8ui78u57C2vfnUJ1YFuyl8IsrNrUvezBnuLFPso-PTXzamr8HeP8XtKNoydB7J7iBt2dQa7Oo_tDgXq88Ai_kUbHMXlX93ne3NnkXyLpsXwhRgsiFkzBN7F98GlX8Y3yn_bb1X7-Lt7fdflMFSesp4w0bOkvarWt0f0PPmK3ITGaCZJvtsvIdEahpV-dVRCMBzVExS_xDg3_-RLTmKRnxzdm9Hy45x_HyiYzM-9_wWPMe4w

Before screenshot:

image

image

After screenshot:

image

image

@Peechey Peechey changed the title Fix ItemsTab Edit Display Fix ItemsTab Display for Betrayal Uniques Apr 28, 2023
@Peechey Peechey added the user-interface Changes that only affect the UI label Apr 28, 2023
@LocalIdentity LocalIdentity merged commit d230546 into PathOfBuildingCommunity:dev May 4, 2023
@Peechey Peechey deleted the fix/vivisect_itemtab branch January 4, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants