Skip to content

Conversation

@Regisle
Copy link
Member

@Regisle Regisle commented Apr 25, 2023

Reopen of #5762, I have misplaced my local commit so cannot revert the branch to a state that is able to reopen it

Instead of each mapmod having its own input, this allows you to select up to 4 prefixes and 4 suffixes, as well as what map tier the map is from, and the map mod effect (from atlas tree)

image

This also adds more map mods,

future improvements may include:

  • supporting more map mods,
  • exporting the map mods rather than being manually maintained,
  • allowing the end user to input the rollrange of the mods that roll,
  • hiding mods which cannot showup for a given tier,
  • and maybe changing the labels of the prefixes/suffixes to be the label of the mod selected rather than the basic "prefix"/"suffix"

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Apr 25, 2023
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll see if I can work on exporting the mods and parsing them via ModParser. It'd be nice if they turned blue/red as well in the tooltip at least

@Wires77 Wires77 changed the title Config tab map mod improvements Improve map mod selection UI in the Configuration tab Apr 28, 2023
@Wires77 Wires77 merged commit 1191385 into PathOfBuildingCommunity:dev Apr 28, 2023
@Regisle Regisle deleted the ConfigTabMapModImprovements branch April 28, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants