Do not modify env.configInput.conditionLeching directly #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently with overleech env.configInput.conditionLeeching is modified directly resulting in default value checks failing on it as it was changed to non-default value not by user input. This force adjustment of configInput is unnecessary and it looks like just modifying condList is enough. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
LocalIdentity
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with overleech env.configInput.conditionLeeching is modified directly resulting in default value checks failing on it as it was changed to non-default value not by user input. This force adjustment of configInput is unnecessary and it looks like just modifying condList is enough.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/883kGHg1K54F
Before screenshot:
After screenshot: