Support trade inversed mods and improve flask mod's behaviour in trader #6118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
changed the title
QuickStick123
added
bug
QuickStick123
changed the title
QuickStick123
changed the title
QuickStick123
changed the title
LocalIdentity
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Some mods on the trade site are listed as being negative value of increased or similar instead of in reduced format. This adds code to switch these around as well as fixing a bug related to flasks not being parsed correctly and projectile pierce.
The only remaining problems are weird parsing behaviour from trade site (e.g. "Arrows Pierce an additional Target" has ranges for each of the mods but no #), legacy mods(still exist but have a weight of zero or unreleased), missing mods (on trade site) or multi line mods e.g. trigger mod or similar.