Correct burst damage when using unleash #6102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Apr 22, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* Correct burst damage when using unleash * Improve burst damage breakdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Unleash is somewhat unusual among repeating damage systems in that it does not modify the average damage of a hit, instead applying a simple DPS multiplier. This made Average Burst Damage inaccurate since it did not account for the less multi on unleash.
We could possibly try to refactor unleash to modify average hit as well, but that's a larger job. This simply adds the repeat penalty to the average burst damage calculation if it's present.
Steps taken to verify a working solution:
Compared the damage before and after change on:
Arc + Unleash got lower burst as expected, without unleash was unaffected, and frozen legion was unaffected
Link to a build that showcases this PR:
https://pobb.in/khQPsbXfIEbC