Fix Juggernaut Unbreakable not working with Iron Reflexes + evasion #6101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Juggernaut Unbreakable node is meant to double the armour received from having iron reflexes and evasion on your body armour
Wires77
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
I briefly looked at this the other day. This works for now, but someday I think a refactor of these calculations might be in order. It seems like we should base values of each defense type on gear, then converting or calculating totals afterward. There's a heap of caveats to that approach, though, so I'm in no rush to do that work now :)
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…athOfBuildingCommunity#6101) The Juggernaut Unbreakable node is meant to double the armour received from having iron reflexes and evasion on your body armour Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Juggernaut Unbreakable node is meant to double the armour received from having iron reflexes and evasion on your body armour
Fixes #6096