Support for Crucible Mods #6076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show button only for weapons and shields
"Allocate" mods - substitute id for name
remove crucibleControl as it is not needed
LocalIdentity
approved these changes
Apr 20, 2023
LocalIdentity
added a commit
that referenced
this pull request
Apr 20, 2023
* Initial Support for Crucible Mods on items * Support for Crucible Mods (#6076) * add new button for crucible mods, separate by node show button only for weapons and shields * add button to remove crucible mods * refactor node dropdowns * Fix Notable export * Fix projectile speed stat * "Remove" button UI refactor "Allocate" mods - substitute id for name * checkLine update * dynamic buttons for normal,unique rarity remove crucibleControl as it is not needed * populate dropdown with active crucible mods * unique staff, sword, helmet * unique helmet update * Add blank parsing for crucible uniques * canHaveMod refactor, Quick is smart * refactor custom tagging --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com>
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
) * Initial Support for Crucible Mods on items * Support for Crucible Mods (PathOfBuildingCommunity#6076) * add new button for crucible mods, separate by node show button only for weapons and shields * add button to remove crucible mods * refactor node dropdowns * Fix Notable export * Fix projectile speed stat * "Remove" button UI refactor "Allocate" mods - substitute id for name * checkLine update * dynamic buttons for normal,unique rarity remove crucibleControl as it is not needed * populate dropdown with active crucible mods * unique staff, sword, helmet * unique helmet update * Add blank parsing for crucible uniques * canHaveMod refactor, Quick is smart * refactor custom tagging --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Moved Crucible mods from Add modifier to their own button that shows for only weapons and shields
Dropdown for each Node, Tier in each mod.label
After screenshot: