Skip to content

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Apr 17, 2023

Fixes #5462

Description of the problem being solved:

Some support for colorblind users; give users ability to set custom hex colors for positive and negative breakdown values. In the tooltip the default values are displayed so users can always reset. This does not interfere or interact with the node power color options functionality in the Tree tab.

Steps taken to verify a working solution:

  • Happy Path (test with valid values and check breakdowns on tree, skills, items, check settings.xml, restart application and verify persistence)
  • Change and cancel, open Options to see previous valid value
  • Test with invalid value starting with "0x" and save, open Options to see previous valid hex value
  • Test with gibberish text and save, open Options to see previous valid hex value

Link to a build that showcases this PR:

Application Options and New Build

eNqtXG1z2roS_tz8Cg8zZ-beGUIs2fJLJzl3CCEpbUgIJE3bLx1hC3BibGLLIfTX35VtwKHY2IFmhmOk3Wd3H0mrF4tz-r-3qSu9siB0fO-shhpyTWKe5duONz6rPdxfHhu1__17dNqjfHI7Oo8cV9T8e_TpNH6WXPbKXNCTQY_TYMz49yWW8hvKZtTjE-Z7XfrkB1e-fVa78T1Wk4bUsx2-_Ga5NAxv6JSd1QYWKNckGlrMs1vr8lRwQgNqcRZcC7vNiPtd34ZaHkRQO6WON_CtZ8avAj-agVs16dVh80Sm0-3d9u8zLjle1iWI6dNpz6ULFgw45VIIH2e1JlBDx-yCTuET0KgbARQ2CZIbiqrrhkm02kmh7nkUhPxDAIMZY_ZKB2HUwGj1l6fUC1h7NGIWd15ZK3B4a0I9a23ZaKh5mluk1Yah4yL5buRyZ-Y6LFj72SB5Gl_-MkCMPNl7n1P3ojdYiSpE12WEGgZR8A4tn6-05DzJcxfI3cA3kWLm0vPo8MnfSqaiGapMir3qjD2Hs6wexpqBG_BhItDUi2z-rawQ09RMtYEwRqZBipR7vhP63odprMJPK3JdyA1ZFVXRVazpDQXpsoJQnmafhSx4pdx572lu07X86dDx3jdEakppFJvqUo-2_HDdP5BeJNpjAeQh_k5D3qEwYJYPqSurQhBpILL8wyUsbsfJNX3tjFh5yUpRpQpVvflYHO1BWbnKwB9zqA9Zu5zkwI_ckpI8kyw1kj8qXrKSBSn_gr2txYhcAJiVRPmjpOOtw1CL8N4JGvn-vfo8ntZ3URPnnfaXXoYfSJO6LtKdSeRch3uTRehY1O3SN2caTWGeuafPbG0QEVPP763jCfcgc-UqY5Tr8KUTsI_otXzX_pDehPphnqJpGkVDshQbsOawPgvpjmdl-l4R7oMXxAk8u1Yp5HvE-jAExepo6LLSOmsz6VBea8pysbEx81KLi3LZ65oxa3IFy8k-5WsPNVluaLtXYCKNr3WIWki1EM5SXTi7bGG6AP-9RgXShOJ20mDdUGhuO29YBzVZW_7l5miPBePFYOIw1y6R0TPSSz9bdFYi_Qras9pZ-lFJe5V6VFZ1O0O5qo80sMvNUlV9eqVhNiVj0ywmLJF_x1U-WV0GC2VQsdnGel_O37b4T2LT4lZTawZTPwpKNnoi_C6xqbtmlGTj1md2ZJWbws5d2IGWdR_cct1KGk3OqfV84dtjVslIdY1BNJtB8hCtvqGHtaLpEFbzTmYZdKzg3dK30GlLDV4xb5Y3sJYubWC1GihvZUOlfCxiLt80o5URL21idRLQhbQwhfQfHyl0_cxM3UBKbvvAjq7UhiwWfL9bzB_o_hycn4izorCaNCx71ovNXFcC5v1ZlMZ_J17KQNuzo0AMh9I2NjWyZpbc3ztTSJlheEE5lex0vfydBg71OI4PskJGA2tyDa1_SV13CEngrJYtFd82FJFQFPinJ_FpnXjqTGd-wOPCFnWtMLbe8WYRl7z4oG3qhNbvYTQaiVMzMMCD-CiwfXnZbt13vrdTh7Mq4bPjur-9aDoUx0DJf5emP50OWJw5pTAahsnjWe27w-YDoXXBOHVcINHyXZfOQmaf1UbUDcGyA4-xzACYsXgBWiwFq-HlIVsGKzkYFFDr-nyg9hsLOIQLs64VOCzXrVX9Dp8Sg2JGFu2bhyaOq_KBkoTfoiFPVgw5RMVHhfko4qwuNxxRWaALXYa6uZbT2h1M8MWMhTAHOyPHEkOjuMXvQTqRKuDFsmBUWYs8oPVZYz5GfJyXB5BU5isnR2t52mltAavxsV4uq0ltvvoFs2hu7EllvvJqEep7QFMeykqqAOnG9-JODoOm6bhihslt2bbLViL5gLd8woJk2spF6kKKWooUDpzAGUY8fxhnJAq4infOOQyJunzVZCOYE4OoK8hE7_ZCOYRmZfKhki1EbiIrUk1WG7n8pWuXgiZIV-c59Ce1BSQs9yg58afVBYMkzr_NV9-xkwVsznDZECtKGLBU3x8mXozvD7O5TN8f8dKl4XNue6e1-eoPsH9z-GILynoe3gkiBtV-CGJs7YfQz19H9IuXEHH-umAjBkQXJrCVTEH78si7gEmOF7RtSajYre0DYR1aJawklW-NtDJi0kHTw8yiPpyI7ACCuehLwWqnHNJq5_SFUVe8R_Pd_QD_OrTdK06fh9SzL8SZz56BiiOjaAZgS89uty1X1026iXp6stxHnMZrt1AKYYNxxabh-QI2hJdidtp4ZUdjYtO1PU92N1mdpTmbjWjkivK7iIrEIjZZmdLr5PKB5wfT1dE_QE38uUiKCaJYSoYw11xfJzVNl6dgwtySr4Sd1KE4TBSXpYXxzYLm2us44thvx7PcyGYdL90rrxrApUPhm7hNIU65VxSGri8OiXx7IS1nxw3wle1Pp-Biqn_l-kPq4iVKeu0Cy7V39WhlRQB1xCLW91g4oZyLndlLEngnXiHGJKaSPRokzTBmU1HbhV2ZDTvRkw4Hkk4EUyexb_C0DTFul81Al8ApWVj0p8hL7Ih9oziSe-_gScmwya6o0-aPLyeIDewz67lRuJ2AopBXvSgPaVvg26JszsV4YbaUATp4uE3bZrY4U0uG6J4hF6FVDjsGkwSalN2EH7KtxYnz-0Pbfdt8B2L1theA0hKxKhG7x3rqenoPY5B0so_Hvx2nbNSptjSo1tfLRwmlLl_sE98GQunIUr0kpNMkMcYTyMlyBomnxWQ2FI_3AbR7OunFECidcOBL9qab8FkW80EI2XCR7nDFHOL5tpjEMCEI1QkyiVJHsoHNuoJlE9Ux1mWljgnW5LpqIt2oK4ahqXVsGkSrE6ITuU4wRkJG10mdqApR6wgZUK4qCgIZDZukrmjY0OuKqsogL95w1lXVAIOqoRl1ROBDQRhDKVHANgb9uoo1BdexrhtGDFLHsiEDhqyrUKnLGqljQwYkrKqmBt6pCMo1UKgrpga1SDUVGWQURfhugmVkIhW8UzUEIgZ8It2UjTpgmXViQpRQbCrgkImRDAwQpIJpTRVREBk4MUxT4GId3EdAjCHLAGWApbqimFAAxYqwIAt2VB0YVIhiqCJmRXingjmgWgN_NQJsaoqGIHYN3AIXoYBgRRFsYVI3TCwLFjA0iaFD6AirgjgdqutYMeGZaMCwYuqAAexAAVCJBJRgFCHVgLg0Q0ShiDaCSl0VHukADnFqsg6P0BoY9HUVnID2g3IVmULTkIEQzYB20pHAxjo4hKADAPNE0YAEoB5QTU3WwDI2oRYcAv4VIuI0EQGKDWQIGBVqVV2FNtagg0HHwsA_ISo4B02qiA6kIkGmqepAl7BKoL9pojuCEUVRwHWkmRAXNlX41LW46QBcNQwIADoAgWYgBJqBGIagURbBQJcmoi_qak3iMFwyt0gxSi-IJsMjGXUP_esko0w4n4WfT07m83ljRvnEH7E3x2UNy5-ezEAJxtxxnDuOBexJE_6dj5vN0fTWW7y2X-5_oOHjN9MJuk3qmueyf-NdLX5_fw7M_uD6-WV2c_PqPQ2Pr352x932zy-P35s_x5Bl3tp3zteZPwmfzn-YDw-2ejUc_Ro-vo3CbvsL7z5S4342GL4ELb0ddM6Hj0P-8EO-Iopnf523BvPZ7yZHV8o1_vkwf7wP2tbo7tfD5eTqOPz1NPTRmH277Y6f-MPTj1HwY3Hc6dz2ul3t8svVzXhw_XPmmV_bf86N6O6rTc9_zKeLX_37iz_Hc9oMVVuJ_pjKcDhW-p0o4Hffr0P65_7h7uXu8vLl5a7df-10h03ce-z-mFmvPnqKtN6Ctcit1evP6a0TPB9fmm-Ppj3BrIme7sj4afHifRs4s-HYVa_8p28P_e4YQtOM-f3tt0Chra_3x1DZbCbpcNkyp8lN3PAkTY2Q6-K0KJKheLjxOYvfPojC5Zc4VYqXA-mLDZg9RP774_vTn5A2TbkBucGUNSzrSEnK002Ami78OeUXDmTOIN5zLvO4EPxxVjuGwdIgMsGGoUO_TV-OxLNDmp_F83JPEoUsuSr2yOjM9-LizHZBiMZbBSXpk30awCzyWeo3--2jGwhBCBzdsyDwA6kLE9NRK6AjzuzPknDqqBewkfP2WRK3jwu-DKJRmS_ppuazhOWjlHlw5Xj1dxTz1GcvnyVNP-pMZ65jOUIGHf2HHOv__UfcrQbKJO5LY9iQSNSTVi-upOTNlTSfME9a-JEkTiYSCTZdHLX8IIhmEFnc0iLsFUFiO5XP4_udFuyMJAd0ekPoQ_G0F79dgoXAqzhgEFVJCjgpVkjMSGitouxSOfdhQy01h4swhJVZwp9EKtg8hyXBpj6uoB-fSEnKB6KUBnM62zStfgRoj_BTDHwAjO0BaQcISDtAQB_C2BYQqtK5tvVO5QCM4ENFU6W_fWHulPG9-Ngy2LS9PcCVEfY2qRyKf3KAzoAOMDzQAfxQK_aEQ6UYvO-IVA9AYPU542ApVtk3frznEK7mwOoAdZ8-mKwt9kHYPrDJ3gjaoZoVHSrHVO-a-_Oo7t2W5DCdqkrwzWnkMn6ATKgcIKEoew5KdU99dBj-PzxTVu60amWNj6yi9mSV7JurD9Qs6qGSy8HW1R_eQlXQ64uDbbx3asKHaYODzRSH2PCpH4upKvn7z_EHWmyQvR3Zf4rTqiaDfZPH3waTU5_lm4_4QC2-Yex7I2f8131hcRbkiNsH8Q1DaM-aNPR9l1EvPa_7-4qxFYXcn3Z9O1xfSUYy_PtHmvoBk2h8S1YKxTXYIySK18dZjjdyHYtLQ3GhEzSPYkU5o23Hr-KkucMnK6n1bW6LTXzXZkHqChNnXulP85d3nfXsj6m2yac_I_Fdt089cbdorVmsuBwfq1vVOtaMYpXs7_iXamS3yvL29FJF2eHZ6nbeUsFQjB2evX-bmgkKpz8rPz1ZdpnTk83_5cT_AaqL93A=

After screenshot:

image

image

image

image

image

image

image

image

@Peechey Peechey added the user-interface Changes that only affect the UI label Apr 17, 2023
@QuickStick123
Copy link
Contributor

There are some hardcoded negative values in certain places e.g. boneshatter breakdown and likely others would nice if this also works on them.
image

@LocalIdentity LocalIdentity merged commit 0ffb658 into PathOfBuildingCommunity:dev Apr 24, 2023
@OzoneOOO
Copy link

This feature is amazing, thank you so much!

Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
…athOfBuildingCommunity#6070)

* custom hex colors for positive and negative values

* text update

* keep colour consistent in Options

* update hardcoded negative-state fields

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
@Peechey Peechey deleted the feature/custom_hex_color_option branch January 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree Colorblind Options

4 participants