Fixed incorrect display of leech breakdown #6030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a display bug of leech calculations when instant leech is in effect.
Description of the problem being solved:
With the new instant leech mastery, PoB added a breakdown of instant leech as part of the calculations for life leech rate.
The breakdown is located under
Calcs > Leech & Gain on Hit > Life Leech Rate.The breakdown however uses
instantLeechProportion * nonInstantLeechPool, instead of using the total leech pool.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/U-bPLFcSdcB7
Before screenshot:
After screenshot: