Fix active skill mods applying to Impending Doom, Prismatic Burst, Predator and Shockwave #6015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Apr 11, 2023
LocalIdentity
changed the title
QuickStick123
deleted the
Stop-active-skill-mods-applying-to-support-gems-with-active-part
branch
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4684 #2719 #2295
Description of the problem being solved:
Active skill gem mods cannot apply if the skill has the support gem tag this includes a fix added in #5530 along with one for the item mods to hopefully get it merged faster.
Link to a build that showcases this PR:
https://pobb.in/iH6RqTU-zfT0
Before screenshot:
After screenshot: