Skip to content

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Apr 4, 2023

Fixes #5921

Description of the problem being solved:

Mods with both Ailment and Weapon1H flags like the Sleight of Hand passive are not applying the increased damage with ailments to poison, bleed, nor ignite.

Steps taken to verify a working solution:

  • Wield one handed weapon(s)
  • Custom modifiers for poison, bleed, ignite 100% chance
  • Allocate Sleight of Hand passive
  • Check Calc breakdown "Total Increased" on each damaging ailment
    --
  • Tested with 1 One Handed Weapon
  • Tested with 2 One Handed Weapons
  • Tested with Viper Strike
  • Tested with Two Handed Weapon
  • Tested with No Weapon
  • Tested with Physical Spell
  • Tested with passives that give increased damage over time
  • Tested with passives that give increased damage with ailments without weapon condition
  • Tested with passives that give increased elemental damage with attacks (checking ignite)

Link to a build that showcases this PR:

eNrtXFtz4jgWfm5-hYuqeVoa8B1SyUwRyIWtpJOBdPfsU5ewBXgibMaWkzBb89_3SLLBEMuxMVWztbWdqQxY5_pJ5-gcIXL-y9uKKC84jLzAv2iq7W5Twb4TuJ6_uGh-fbr-3Gv-8nPj_BHR5cP8MvYIG_m58emcv1YIfsEE-MymQlG4wPRbKkr_AaLWyKdLHPj36PcgvAnci-aXwMdNZYZ816PpO4egKPqCVviiOXWAuamgyMG-O9w9TwiXKEQOxeEdUzuIaXAfuDBKwxhGV8jzp4HzjOlNGMRrsKqpvHj4VdCM7x8fJk8Zkzw_axK49On8kaANDqcUUSWCXxfNASCDFniEVvAbpCESgyjDaOu6qtmGbXY1S212Cpkv4zCiBxI0ra1apqXbum2qulTCdI2xu2VS27aqyUgfQ3w1n2OHei94GHp0uES-s1NotaWc1anvY0K9NfFwmLHNlHHcvhOvdrsy4qeAIjJ6nG5pbbPd65uqoem2Zhh2MV9At3xSDZcEMM1qMNo9EK3BP5hTy5Dxfffo8h1vr9u2Ldu0DLNvmraUd7zwPYqzjKrZ7vb6qt0zbVvXtSKl75n73Xa_Z-hat2_0bbsvXRKBFwV-ltFs62q_b33AcLBU1bZmg7oiE99rUo1e2zZtXTVMXTPMj6Ztzzut3YPZtrW-1TXMnnQhxoRAKspySud8giMcviDq7RsppR8Gq5nn70-1aoFHKsyZCfPVl4bsPfLRMIh2C9EsonzEISQ6usfQ_YBhip0AcmOWpdc2rRJq8pml-u68OS5PWcmVhKGqNcf5cTUtS1dZ8HEGTSC-ylFOg5iUpKS7ZKwXBMIfWUJNmjtG-G0XkGaBuCyhKo2KsU_LWZclNDS5dS8B5YXCR7DwBHN1-7hzGRKTavV1U7VU29KlqXC5iTwHkXv05q3iFexhT-gZ7xRqui5fqIsl9SE1yXhVQxqs116Ij2AbBsQ9hm2JgugIPhaKZZCA8sU5Y8Rj3ykX4F_9kKfqTNVTiPQcTyDuWJ01I7gsy05JEr5lChOha4H9ROGmnEN3GDvLGyhMJ4hmDOy2TcMoytg7k_R-IbyMuBS8jDAH3gL5-xwVsGKM-Vhp7UKv89GS518fh4vNdOlh4lajTg0bonWJ1MpwznKXwntfXaWFk2WtCMl3FLrlNqCqNr2gKJtx1V4xXIK83MrEUFYDg4sP-oSuvNkJfmetDqnGNghXQRyWnHBBXMqBdLMQlfMEu7FTbne6JNCuHjZHZoFZhOSxyB2mFDnPo8BdlMaIK6nOMY3Xa8gUbM7L8rG9DgpzL1PdfLZKUD_Agi0Vt2xXLK9gR11awXanL6_lgKW8L2yrruDMjry0iu3xwT2khBWken76cB9kDyC60sV5De1Yqd6KE-53fPLACl7B-CU7WIqqUUNVsys4paaE2P9zU1r-HnkpBVe-G4csGkrrOOTIU_PkrSBjRtEIUaS4SSn8DYUe8qnGT70ijEJneQezf40ImUEOuGhmn7J3B4wqY2Tyzzv8ZI-9Gq_WQUj5wyEiTsS1j_11TBWfn8qtvMj5MYvnc3bEBgpoyI8Nr66vr4ZP429XicFZlujZI-SHH69m7PRI_D9V_el8innmVKJ4FomXF81vHn6dMq4RpsgjAKITEILWEXYvmnNEItDswUtOMwVkHFogjVNBsZuecuTL2hHIJV294ZCCv7DlOqGHpXZtxz8wSihk2zGbYJk0dsYlFyQS_hBFVJQLEqT4saJcCjvjk7rDBgt4Yc0gItWcjH6ABN2scQR7sDf3HBYbxVP-BNSCqgAXx4GwcjYF851sW3IZ_PBPJkAMypnFCZmMOxktQJWfAUpRFaNy9hF2kNR3MShn3laggQ8wyaRsqQokfUkOFyFoBh5hW4x0Zq8I3pLIBT7QJQ7FviWVdA85KiUpDJzQm8VUHsYZigKseGcsQYiNyVlF1yfxgY0VZKK9PkgCaJZGLkr0D9JEVsQqyg0pfknxUjAFSXUugV-MFoCQNigS_5PhgiDh-XfwEniuKGAl4XJAVpQwoFSvL4YX4_XFHJbp9SVeExQ9S-c7GZWzf4X-zaObHCni47xSQlhQ1ZPAYquehMlhIbHjnRSXEDx_jfAcA9CFCWxLUzC_NPZHsMnRgrktKYqblR8IO9cqyRKpPNfTyhLFAk0OK4vWsCD5QBDsRbcF1U45SdvW6RYjwj4OC0g9ge8OZWv5GdAI-e6IHfjUdJSdF8VrEJZa9pBXru6m9FDqeSdtJM557RYpEXQYN3gVXW6gI7xmu9PBx2-IA5sU91S0N1meVJ2L5ygm7PmvMWKJhXVZmad34qaCH4Sr7bE-iFoGrywpComslIxgr7m7EyMDQhNhTF2Kl0AnMYi7qfJnyUN-D2Gws5p7zO32fIfELh77SbO8nQCCZsw2dvWCHWS72RsNGUlbRZ_OwZ6E-IYEM0S0lCW9kNHcG1bTYd5-jV3WVa1Z4xl6z_D0D-HkmFeDHLCmssAr9v4emi4XGs3OmAIEHYZDhxsDr_JkcNQP3IA144uZYz0gO11L9CsJc0fAJwQfCaXvkQpAMupTQTnyXmC1PuEVLB6aDyanfUShQKEEtPky88Ddit6Bk4e3EKiMwxy0k5ewmnmIishkL59CjNMA5FLUZPHDm-wdHeZNl6EcURxukmqbTYMfuCyg9K7WNVt93TRbRr9v91pmr6frLa2naWpL7_cstaUZlqG3-moPnpq20dJ10zCBTtNbpmr3LCAw-lbL6tq63VJN1TBgsGv1W0ZXBUcpWJq5eqSpya0iYZlw-OvkTkz5ktJ1dNbpvL6-tteILoM5fvMIbjvBqrMGJnD3M4f1MxPbGcC_y8VgcHX7W_-f45fRw8ror-xvi19fH77PTGs0nKAfm-f1PHpQLx82v3vqr59DYLkQKKdaz8XVpKiTIA4QcrQZxuzFlwBaCzbGHqZv-AywA5Dk8AbihcH6ZxCs_sUOAO22adtGN_lPJC3Yg-g9Wm-TCyNOkp-RJDzolkcezFLI99p0JTHC30Cq3tfaMBvJP3Hid87XaLIW2Os0F8cRFh99f8doHfj8cSZNMtJsipygENbxmTIZTK4aX8AvRtD4ggB-V7mGBqExDNGcYvdMYUY1HkM8997OFHZHq-DNNJ6XeZMk8zNF6zaS6ThTbj7DT2O8WhPP8dgDtfFvihbRGRTK0HI4uEWgyGwhfrTy102IoCdVdIVVngrLYdBZrTYKbIh8lu8Dd4L8BVZC9hsWX9tsJgAkM8883sdG-z82Umz0ImxuWIgr0yXyn_-LsHHAVPZx0F969ye2UYUYQVmkiO1DGSajyd6niHOno_Ex_o9PIT5mET6TGDYsV7lF1FnivyG8Jp_hJwtRV-KF9T_hhV3kxWCN35QhwQg6ir9psYqfBt8sJ_iPM8Xu7q_ff2iwYmmgJO2Dkog6ZnGy1kG-d-53FSSANgN4HmdQTPCyin-UAgHzwpppNiTqnE4xg1CjqDsW9SOWywCaR2Uw20QRC0kOl2JW0HmJCT3k1yrw89MXRT_CS2X6itaHqo1jBNVwP5GhnUBGvkPWCRyyTuDQUTLyHFKrLK681amfABHtVN5UWW-3mKwwrYVHTrBZtS3QKkuorVI_Ff7mCRaDeoLwUE9gh1FxJZwqxWh1I9I4AYDV94yTpVi9rv9azRCuZoC7UcSHZXXWoKgt6kjID2yztgTrVNOqnirHVF-a9XE0as-leZpFVcX5wSommJ4gE-onSCh6zaA0avKrp8H_6J2y8qI1KnMcU0XtWLRjUDXr5uoTTYtxquRysrr66BaqAt_E8xeVZj0_NWmnmYOT7RSnaPiM43yqCn79Pf5ExYZZ25D6W5xVNRnUTR7vFYpTn_STNf4hCr9OG_hzb_Hucmx6qs7u0e1fqR18u5oMbvIu1GJ2xD6OLoMo2pHzr7S_p3XiiAYrkJwhVbvdn9gX630Hs6OtNb-K2GgcPPb8OfEcqszYPUfgazQWYKPCqYK5sk6-AaG4_AN_BUUKfqMhUuZeiJOH70TyW4uNHDMP_2rAh36JPyfwIRmHaur9iR_Zl5oy9PfgU7wqsiT5YwG5Kh4JcvAyIC4O9xSJL--nV5zt7Pel8uiTb48EhPBzxCxnMWOaKbaXqbN_UCCPIfuN_5TJ_JglvTKdsugf2LW9kbdl6NvFHPtfpNkxalZ6eySJm_PO4R-k-A-YTCw4

Before screenshot:

image
image
image

image
image
image

image

After screenshot:

image

image
image
image

image

@Peechey Peechey added the bug: calculation Numerical differences label Apr 4, 2023
@LocalIdentity LocalIdentity merged commit 9631bf9 into PathOfBuildingCommunity:dev Apr 22, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@Peechey Peechey deleted the fix/1h_weapon_inc_dmg_with_ailments branch January 4, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sleight of Hand notable and the surrounding One-Handed Damage passives don't increase Poison DPS

2 participants