Skip to content

Fix inconsistent display of additional quality and gem levels in skill group tooltip #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Fix inconsistent display of additional quality and gem levels in skill group tooltip #5181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Classes/SkillsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,9 +1153,9 @@ function SkillsTabClass:AddSocketGroupTooltip(tooltip, socketGroup)
tooltip:AddLine(20, string.format("%s%s ^7%d%s/%d%s",
data.skillColorMap[skillEffect.grantedEffect.color],
skillEffect.grantedEffect.name,
skillEffect.level,
skillEffect.srcInstance and skillEffect.srcInstance.level or skillEffect.level,
(skillEffect.srcInstance and skillEffect.level > skillEffect.srcInstance.level) and colorCodes.MAGIC.."+"..(skillEffect.level - skillEffect.srcInstance.level).."^7" or "",
skillEffect.quality,
skillEffect.srcInstance and skillEffect.srcInstance.quality or skillEffect.quality,
(skillEffect.srcInstance and skillEffect.quality > skillEffect.srcInstance.quality) and colorCodes.MAGIC.."+"..(skillEffect.quality - skillEffect.srcInstance.quality).."^7" or ""
))
if skillEffect.srcInstance then
Expand All @@ -1169,9 +1169,9 @@ function SkillsTabClass:AddSocketGroupTooltip(tooltip, socketGroup)
tooltip:AddLine(20, string.format("%s%s ^7%d%s/%d%s",
data.skillColorMap[activeEffect.grantedEffect.color],
activeEffect.grantedEffect.name,
activeEffect.level,
activeEffect.srcInstance and activeEffect.srcInstance.level or activeEffect.level,
(activeEffect.srcInstance and activeEffect.level > activeEffect.srcInstance.level) and colorCodes.MAGIC .. "+" .. (activeEffect.level - activeEffect.srcInstance.level) .. "^7" or "",
activeEffect.quality,
activeEffect.srcInstance and activeEffect.srcInstance.quality or activeEffect.quality,
(activeEffect.srcInstance and activeEffect.quality > activeEffect.srcInstance.quality) and colorCodes.MAGIC .. "+" .. (activeEffect.quality - activeEffect.srcInstance.quality) .. "^7" or ""
))
if activeEffect.srcInstance then
Expand Down