Disable ModCache when running in headless mode for github tests #5179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only causes ModCache to not load on start which allows writing tests that involve mod parsing.
The CI envirement variable should always be true when the headless wrapper is ran from github workflows but should not be set when other tools use it. Should hopefully prevent slowing things down for 3rd parties interfacing with pob.
QuickStick123
added
bug
LocalIdentity
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Tests fail if they're implemented in the same pr as parsing for a mod that they require due to the github tests runner using outdated mod cache.
This pr implements a headless flag that prevent loading of mod cache when running using the headless wrapper and also separates ModCache rebuilding code into a separate function.
Steps taken to verify a working solution: