-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Correct Fanaticism tooltip #5103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
changed mana cost to skill cost
|
did I miss anything in my submission? |
| modList:NewMod("Condition:SacrificeManaForLightning", "FLAG", true, "Config", { type = "Condition", var = "Combat" }) | ||
| end }, | ||
| { var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced ^x7070FFmana ^7cost, and increased area of effect)", apply = function(val, modList, enemyModList) | ||
| { var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced skill cost, and increased area of effect)", apply = function(val, modList, enemyModList) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik Fanatacism only applies to spells. https://www.poewiki.net/wiki/Instruments_of_Zeal
| { var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced skill cost, and increased area of effect)", apply = function(val, modList, enemyModList) | |
| { var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced spell cost, and increased area of effect)", apply = function(val, modList, enemyModList) |
|
Also you probably could clean up the description of your pr. |
|
In the code these mods are flagged as casts instead of spells and only work on self cast? I don't know if this will causes issues either. if modDB:Flag(nil, "Fanaticism") and actor.mainSkill and actor.mainSkill.skillFlags.selfCast then
local effect = m_floor(75 * (1 + modDB:Sum("INC", nil, "BuffEffectOnSelf") / 100))
modDB:NewMod("Speed", "MORE", effect, "Fanaticism", ModFlag.Cast)
modDB:NewMod("Cost", "INC", -effect, "Fanaticism", ModFlag.Cast)
modDB:NewMod("AreaOfEffect", "INC", effect, "Fanaticism", ModFlag.Cast)
end |
|
@QuickStick123 This is just a tooltip text change so i don't think it matters. |
|
Thank you for your kind words.😊
…On Mon, Sep 26, 2022, 3:31 AM Paliak ***@***.***> wrote:
@QuickStick123 <https://github.com/QuickStick123> This is just a tooltip
text change so i don't think it matters.
—
Reply to this email directly, view it on GitHub
<#5103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFGMGDBSLO55Y3DOAQV7FTWAFGLVANCNFSM6AAAAAAQTD6DJU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
changed mana cost to skill cost
Fixes # .
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: