Skip to content

Conversation

@tinycrops
Copy link
Contributor

changed mana cost to skill cost

Fixes # .

Description of the problem being solved:

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

changed mana cost to skill cost
@tinycrops
Copy link
Contributor Author

did I miss anything in my submission?

@QuickStick123 QuickStick123 added the user-interface Changes that only affect the UI label Sep 23, 2022
modList:NewMod("Condition:SacrificeManaForLightning", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
end },
{ var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced ^x7070FFmana ^7cost, and increased area of effect)", apply = function(val, modList, enemyModList)
{ var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced skill cost, and increased area of effect)", apply = function(val, modList, enemyModList)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik Fanatacism only applies to spells. https://www.poewiki.net/wiki/Instruments_of_Zeal

Suggested change
{ var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced skill cost, and increased area of effect)", apply = function(val, modList, enemyModList)
{ var = "buffFanaticism", type = "check", label = "Do you have Fanaticism?", ifFlag = "Condition:CanGainFanaticism", tooltip = "This will enable the Fanaticism buff itself. (Grants 75% more cast speed, reduced spell cost, and increased area of effect)", apply = function(val, modList, enemyModList)

@Paliak
Copy link
Contributor

Paliak commented Sep 26, 2022

Also you probably could clean up the description of your pr.

@QuickStick123
Copy link
Contributor

In the code these mods are flagged as casts instead of spells and only work on self cast? I don't know if this will causes issues either.
#2347 #1834

if modDB:Flag(nil, "Fanaticism") and actor.mainSkill and actor.mainSkill.skillFlags.selfCast then
	local effect = m_floor(75 * (1 + modDB:Sum("INC", nil, "BuffEffectOnSelf") / 100))
	modDB:NewMod("Speed", "MORE", effect, "Fanaticism", ModFlag.Cast)
	modDB:NewMod("Cost", "INC", -effect, "Fanaticism", ModFlag.Cast)
	modDB:NewMod("AreaOfEffect", "INC", effect, "Fanaticism", ModFlag.Cast)
end

@Paliak
Copy link
Contributor

Paliak commented Sep 26, 2022

@QuickStick123 This is just a tooltip text change so i don't think it matters.

@tinycrops
Copy link
Contributor Author

tinycrops commented Oct 7, 2022 via email

@LocalIdentity LocalIdentity merged commit 9f8a90e into PathOfBuildingCommunity:dev Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants