Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "FIX: fix jewels applying to the same node twice if overlapping" #5065

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Revert "FIX: fix jewels applying to the same node twice if overlapping" #5065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,10 @@ function calcs.buildModListForNode(env, node)
else
modList:AddList(node.modList)
end

-- Keep track of what jewels have been applied to this node to avoid applying the same jewel twice if they overlap
-- Ref https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4873
local appliedJewels = {}


-- Run first pass radius jewels
for _, rad in pairs(env.radiusJewelList) do
if rad.type == "Other" and rad.nodes[node.id] and not appliedJewels[rad.item.name] then
appliedJewels[rad.item.name] = true
if rad.type == "Other" and rad.nodes[node.id] then
rad.func(node, modList, rad.data)
end
end
Expand Down