Fix Barrage and Barrage Support ambiguity #5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… barrageAmbiguity
LocalIdentity
approved these changes
Sep 14, 2022
raylu
added a commit
to raylu/PathOfBuilding
that referenced
this pull request
Dec 12, 2022
PathOfBuildingCommunity#5029 renamed "Barrage" to "Barrage Support"
Wires77
pushed a commit
that referenced
this pull request
Dec 14, 2022
#5029 renamed "Barrage" to "Barrage Support"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5026 .
Description of the problem being solved:
Naming ambiguitiy between Barrage and Barrage Support causes all kinds of annoying edge cases. Preventing the Support suffix from being removed from the support fixes most if not all of them.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: