Fix Aura effect on Self not counting towards Aura effect breakdown #4977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aura effect on Self from Sublime Vision, Purposeful Harbinger or from the Aura mastery were not counting towards the value in the Aura effect breakdown This PR does have the issue where if you have something like Generosity linked to a skill, it correctly does not add aura effect on self mods to the total aura effect value but it does still show them in the breakdown table. I'm not sure how to have them disappear from the table when the aura does not affect the player
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aura effect on Self from Sublime Vision, Purposeful Harbinger or from the Aura mastery were not counting towards the value in the Aura effect breakdown
This PR does have the issue where if you have something like Generosity linked to a skill, it correctly does not add aura effect on self mods to the total aura effect value but it does still show them in the breakdown table. I'm not sure how to have them disappear from the table when the aura does not affect the player