Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stormfire and add support for mod. #4950

Conversation

QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Aug 21, 2022

Fixes #4943.

Description of the problem being solved:

Stormfire wasn't updated or shock mod supported.
The legacy mod doesn't exist anymore so support wasn't added for that.

Steps taken to verify a working solution:

  • Changing number of shocked enemies changes to damage up to the cap.

Link to a build that showcases this PR:

https://pobb.in/Lp6GjQSfj18x

Before screenshot:

image

After screenshot:

image

@QuickStick123 QuickStick123 added the bug: accuracy Wording differences label Aug 21, 2022
@LocalIdentity LocalIdentity merged commit 9ec3ee2 into PathOfBuildingCommunity:dev Aug 29, 2022
@QuickStick123 QuickStick123 deleted the stormfire-fix-and-support branch September 15, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stormfire uses 3.2.0 description
2 participants