Skip to content

add breakdowns for burning and caustic ground from ailments #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022
Merged

add breakdowns for burning and caustic ground from ailments #4916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3291,6 +3291,14 @@ function calcs.offence(env, actor, activeSkill)
end
globalOutput.CausticGroundDPS = CausticGroundDPSCapped
globalOutput.CausticGroundFromPoison = true
if globalBreakdown then
globalBreakdown.CausticGroundFromPoison = {
s_format("%.1f ^8(single poison damage per second)", baseVal * effectMod * rateMod),
s_format("* %.1f%% ^8(percent as Caustic ground)", groundMult),
s_format("* %.3f ^8(effect mult)", effMult),
s_format("= %.1f ^8per second", globalOutput.CausticGroundFromPoison)
}
end
end
local durationBase
if skillData.poisonDurationIsSkillDuration then
Expand Down Expand Up @@ -3561,6 +3569,14 @@ function calcs.offence(env, actor, activeSkill)
end
globalOutput.BurningGroundDPS = BurningGroundDPSCapped
globalOutput.BurningGroundFromIgnite = true
if globalBreakdown then
globalBreakdown.BurningGroundDPS = {
s_format("%.1f ^8(ignite damage per second)", baseVal * effectMod * rateMod),
s_format("* %.1f%% ^8(percent as burning ground)", groundMult),
s_format("* %.3f ^8(effect mult)", fireEffMult),
s_format("= %.1f ^8per second", globalOutput.BurningGroundDPS)
}
end
end
globalOutput.IgniteDamage = output.IgniteDPS * globalOutput.IgniteDuration
if skillFlags.igniteCanStack then
Expand Down
4 changes: 2 additions & 2 deletions src/Modules/CalcSections.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ return {
{ breakdown = "MainHand.PoisonDPS" },
{ breakdown = "OffHand.PoisonDPS" },
}, },
{ label = "Caustic Ground DPS", haveOutput = "CausticGroundFromPoison", { format = "{0:output:CausticGroundDPS}", { breakdown = "CausticGroundDPS" } } },
{ label = "Caustic Ground", haveOutput = "CausticGroundFromPoison", { format = "{0:output:CausticGroundDPS}", { breakdown = "CausticGroundDPS" } } },
{ label = "Poison Duration", { format = "{2:output:PoisonDuration}s",
{ breakdown = "PoisonDuration" },
{ label = "Player modifiers", modName = { "EnemyPoisonDuration", "SkillAndDamagingAilmentDuration", "PoisonFaster" }, cfg = "poison" },
Expand Down Expand Up @@ -877,7 +877,7 @@ return {
{ breakdown = "OffHand.IgniteDPS" },
{ modName = { "IgniteBurnRate" }, cfg = "skill" },
}, },
{ label = "Burning Ground DPS", haveOutput = "BurningGroundFromIgnite", { format = "{0:output:BurningGroundDPS}", { breakdown = "BurningGroundDPS" } } },
{ label = "Burning Ground", haveOutput = "BurningGroundFromIgnite", { format = "{0:output:BurningGroundDPS}", { breakdown = "BurningGroundDPS" } } },
{ label = "Ignite Duration", { format = "{2:output:IgniteDuration}s",
{ breakdown = "IgniteDuration" },
{ label = "Player modifiers", modName = { "EnemyIgniteDuration", "SkillAndDamagingAilmentDuration", "IgniteBurnFaster", "IgniteBurnSlower" }, cfg = "skill" },
Expand Down