Skip to content

Conversation

@Sinured
Copy link
Contributor

@Sinured Sinured commented Aug 16, 2022

Fixes #4855 .
Fixes #4863 .

Description of the problem being solved:

The new Chainbreaker and Kaom's spirit rage regeneration was based on total life/mana regeneration after calculating degens. Its calculation time is now based on after calculating the recovery rate from regeneration and before any other calcuations work with LifeRegen/ManaRegen because of the UnaffectedBy mod.
Additionally, rage regeneration from these two sources didn't add the Condition:CanGainRage flag which prevented any rage buffs to apply.

Steps taken to verify a working solution:

  • checked that chainbreaker and kaom's spirit apply still apply rage regen and their respective UnaffectedBy mod.
  • checked that with 50 rage selected in the configuration tab dps is increased when selecting either of the two.
  • checked that both ragen regen stack
  • checked that the life degen and triple rage buff affect apply from Rite of Ruin

Link to a build that showcases this PR:

https://pobb.in/2oYNHZUtTqFD

After screenshot:

ragebuff_fixed
rage_riteofruin

@QuickStick123 QuickStick123 added bug Something isn't working bug: behaviour Behavioral differences labels Aug 16, 2022
@Regisle Regisle mentioned this pull request Aug 17, 2022
@QuickStick123 QuickStick123 mentioned this pull request Aug 17, 2022
2 tasks
@LocalIdentity
Copy link
Contributor

Superseded by #4880

@Sinured Sinured deleted the fix-rage-regenration-and-apply-rage-buff-effect branch March 8, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Degens reduce rage generation from kaoms spirit/chainbreaker. Rage from chainbreaker doesn't apply rage buff effects.

3 participants