Skip to content

Conversation

@Regisle
Copy link
Member

@Regisle Regisle commented Aug 15, 2022

edit : this the 2 lines below are no longer relevant

Built ontop of #4820
So most changes are from there, this needs a bit more testing before it can be added, and I will fix commits once the other PR is merged

Burning ground added does not use skill cfg, so modifiers to the skill do not apply but global mods do apply, will correctly override any other burning ground the skill has if its larger, and correctly works with full dps as well

need to test if its correctly isolated from the skill

@Regisle Regisle force-pushed the HysteriaBurningGround branch from 90270d8 to d97b509 Compare August 15, 2022 14:14
@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Aug 18, 2022
@Nostrademous
Copy link
Contributor

@Regisle you shouldn't check in code with ConPrintf() statements in the code. Will clutter up our console.

@Regisle Regisle force-pushed the HysteriaBurningGround branch from d97b509 to b90ed21 Compare August 19, 2022 18:23
@Regisle
Copy link
Member Author

Regisle commented Aug 19, 2022

@Regisle you shouldn't check in code with ConPrintf() statements in the code. Will clutter up our console.

my bad musta been half asleep, thought I removed those thanks

@QuickStick123
Copy link
Contributor

This could use a breakdown but It doesn't belong to any skill so I don't know where it would go the calculations are fine though and interacts correctly with other burning ground.

@Regisle Regisle force-pushed the HysteriaBurningGround branch from b90ed21 to 8a513f7 Compare December 9, 2022 02:52
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and decay should probably be refactored into a generic method, but this looks okay for now.

@Wires77 Wires77 changed the title Hysteria burning ground Add support for burning ground from Essence of Hysteria Dec 9, 2022
@Wires77 Wires77 merged commit f12d7b2 into PathOfBuildingCommunity:dev Dec 9, 2022
@Regisle Regisle deleted the HysteriaBurningGround branch December 26, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants