Skip to content

Conversation

@Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Aug 14, 2022

Prior to this PR doing basically anything to manipulate the order of your socket groups (deleting them, reordering them, etc) would cause your active socket group selection in both the skills tab and calcs tab to change.

This is not desirable behavior — users expect their active socket group to remain the same regardless of what they do (unless they delete the active socket group of course, and even then it should come back if they undo that).

This PR implements support for all of that, hopefully in a bug-free manner.

Video Demo: https://www.youtube.com/watch?v=EcbuMPWKr3Q

Example PoB: https://pobb.in/JxITTra78keh

@Lothrik Lothrik added the enhancement New feature, calculation, or mod label Aug 14, 2022
@QuickStick123
Copy link
Contributor

QuickStick123 commented Dec 8, 2022

This is a big improvement though and the current changes seem fairly robust apart from these couple cases.
Changing the active gem here doesn't create undo states
image
Changing between skill sets can change which gem is active. Also changing one skill set will effect the other.
image
->
image
->
image

@LocalIdentity LocalIdentity merged commit a55b8ee into PathOfBuildingCommunity:dev Dec 8, 2022
@Lothrik Lothrik deleted the make-socket-group-sorting-persist branch September 20, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants