Skip to content

Add support for Burning and Caustic ground and Flame Surge #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add support for Burning and Caustic ground and Flame Surge #4801

merged 1 commit into from
Aug 15, 2022

Conversation

@deathbeam
Copy link
Contributor

@deathbeam deathbeam commented Aug 14, 2022 •
edited
Loading

The caustic ground is preparation for Alchemist Mark

Signed-off-by: Tomas Slusny slusnucky@gmail.com

Example POB

https://pobb.in/jucI_sDtoXBx

Example POB with warnings

https://pobb.in/DgY2Nr6ZMVkO

Screenshots

image
image
image
image

@deathbeam deathbeam force-pushed the add-support-for-grounds branch 2 times, most recently from 3dff871 to 8372471 Compare August 14, 2022 19:24
@deathbeam
Copy link
Contributor Author

deathbeam commented Aug 14, 2022

For Alchemist mark this would be just:

mod("IgniteDPSAsBurningGround", "MAX", nil, 0, 0, { type = "GlobalEffect", effectType = "Curse" })
mod("PoisonDPSAsCausticGround", "MAX", nil, 0, 0, { type = "GlobalEffect", effectType = "Curse" }),

most likely

@deathbeam deathbeam force-pushed the add-support-for-grounds branch 2 times, most recently from b91e2eb to d323fb8 Compare August 14, 2022 20:07
@deathbeam
Copy link
Contributor Author

deathbeam commented Aug 14, 2022

image

yea just tested it on warlords mark as workaround and works great :d

@deathbeam deathbeam force-pushed the add-support-for-grounds branch from d323fb8 to a8bd1b4 Compare August 14, 2022 23:55
ppoelzl
ppoelzl approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some of the ignite code has to be duplicated unfortunately.

@deathbeam deathbeam force-pushed the add-support-for-grounds branch 5 times, most recently from 533ceec to a6b3946 Compare August 15, 2022 01:11
@deathbeam
Add support for Burning and Caustic ground and Flame Surge
959ecd8 
The caustic ground is preparation for Alchemist Mark

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@deathbeam deathbeam force-pushed the add-support-for-grounds branch from a6b3946 to 959ecd8 Compare August 15, 2022 01:33
@ppoelzl ppoelzl merged commit f7fc2c3 into PathOfBuildingCommunity:dev Aug 15, 2022
@deathbeam deathbeam deleted the add-support-for-grounds branch August 15, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppoelzl ppoelzl ppoelzl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deathbeam @ppoelzl