-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Extend default gem level functionality #4724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend default gem level functionality #4724
Conversation
.. and add awakened maximum gem level option.
Merged "Hide gems when using match gems to character level if they are above character level" from PathOfBuildingCommunity#4761 by @QuickStick123 Reordered default gem level list so "normal maximum" is first, as "match character level" has potentially confusing behavior (hiding gems below character level) that users need to opt-in to. Co-Authored-By: QuickStick <31533893+QuickStick123@users.noreply.github.com>
|
There is also the issue that it won't hide gems on load either I wasn't sure how to resolve this one though. |
.. and skip rebuilding sort cache on character level change if we don't care about the character level.
.. and slightly improve sortCache behavior.
|
The issue doesn't seem to be resolved and still uses normal gem level stuff when set to match character level and reload/load pob. Everything else seems to behave correctly. |
This fixes a bug where the gem list was never initialized correctly on new/empty socket groups.
|
@QuickStick123 That issue should be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I see with this is that those people who have selected "Match to character level" in old versions of PoB will have that selection overwritten to "Normal Maximum" instead.
|
The only remaining issue I see with this is that it loses the functionality to say add level 15 gems if you want to make a early maps config or something similar easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the early mapping use case is probably niche, and using default gem level then adding each gem individually again seems like a pain anyway, so hopefully we can teach people to copy/paste the endgame levels instead.
Fixes #4630.
This replaces the old gem level selection and "match gem level to character" level options with a dropdown selection that has four options:
Before screenshot:
After screenshot: