Skip to content

Conversation

@Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Aug 9, 2022

Fixes #4630.

This replaces the old gem level selection and "match gem level to character" level options with a dropdown selection that has four options:

  • Normal Maximum: All gems default to their highest valid non-corrupted gem level.
  • Corrupted Maximum: Normal gems default to their highest valid corrupted gem level. Awakened gems default to their highest valid non-corrupted gem level.
  • Awakened Maximum: All gems default to their highest valid corrupted gem level.
  • Match Character Level: All gems default to their highest valid non-corrupted gem level that your character meets the level requirement for. This hides gems with a minimum level requirement above your character level, preventing them from showing up in the dropdown list.

Before screenshot:

After screenshot:

@Lothrik Lothrik marked this pull request as ready for review August 10, 2022 04:31
@Nostrademous Nostrademous added the enhancement New feature, calculation, or mod label Aug 10, 2022
Lothrik and others added 3 commits August 10, 2022 05:05
Merged "Hide gems when using match gems to character level if they are above character level" from PathOfBuildingCommunity#4761 by @QuickStick123

Reordered default gem level list so "normal maximum" is first, as "match character level" has potentially confusing behavior (hiding gems below character level) that users need to opt-in to.

Co-Authored-By: QuickStick <31533893+QuickStick123@users.noreply.github.com>
@Lothrik
Copy link
Contributor Author

Lothrik commented Aug 12, 2022

Merged #4761 to resolve conflicts.
Fixes #4759 #2830

@QuickStick123
Copy link
Contributor

There is also the issue that it won't hide gems on load either I wasn't sure how to resolve this one though.

.. and skip rebuilding sort cache on character level change if we don't care about the character level.
.. and slightly improve sortCache behavior.
@QuickStick123
Copy link
Contributor

The issue doesn't seem to be resolved and still uses normal gem level stuff when set to match character level and reload/load pob. Everything else seems to behave correctly.

This fixes a bug where the gem list was never initialized correctly on new/empty socket groups.
@Lothrik
Copy link
Contributor Author

Lothrik commented Aug 13, 2022

@QuickStick123 That issue should be resolved. self:PopulateGemList() wasn't being called when sortCache was uninitialized, meaning the gem list was always incorrect on new/empty socket groups.

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I see with this is that those people who have selected "Match to character level" in old versions of PoB will have that selection overwritten to "Normal Maximum" instead.

@Lothrik
Copy link
Contributor Author

Lothrik commented Aug 15, 2022

@Wires77 33e22be should handle legacy build configuration settings properly.

@QuickStick123
Copy link
Contributor

The only remaining issue I see with this is that it loses the functionality to say add level 15 gems if you want to make a early maps config or something similar easily.

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the early mapping use case is probably niche, and using default gem level then adding each gem individually again seems like a pain anyway, so hopefully we can teach people to copy/paste the endgame levels instead.

@Wires77 Wires77 merged commit 2474b83 into PathOfBuildingCommunity:dev Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Awakened Gems defaulting to Gem Level 6

4 participants