Do not hide config options that are configured without source #4716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will get rid of the merge commit soon-ish, fresh dev env on other pc :d |
|
Added right-click reset and also tooltip detail:
|
deathbeam
force-pushed
the
unhide
branch
2 times, most recently
from
8107c66 to
80107f0
Compare
|
Removed the right click resetting again as it was buggy with number inputs and I couldnt figure out how to fix it |
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Aug 9, 2022
Right click resets config option to default state if possible. This is related to PathOfBuildingCommunity#4716 but I figured its useful as separate change. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Aug 9, 2022
Right click resets config option to default state if possible. This is related to PathOfBuildingCommunity#4716 but I figured its useful as separate change. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Aug 9, 2022
Right click resets config option to default state if possible. This is related to PathOfBuildingCommunity#4716 but I figured its useful as separate change. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Aug 9, 2022
Right click resets config option to default state if possible. This is related to PathOfBuildingCommunity#4716 but I figured its useful as separate change. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Aug 9, 2022
Right click resets controls to default state if possible. This is related to PathOfBuildingCommunity#4716 but I figured its useful as separate change. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2 tasks
|
Fixes #4841. |
Instead highlight them in red to let user know its an error. Closes PathOfBuildingCommunity#4407 Closes PathOfBuildingCommunity#4468 Closes PathOfBuildingCommunity#1945 Signed-off-by: Tomas Slusny <ts6234@intl.att.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead highlight them in red to let user know its an error.
Closes #4407
Closes #4468
Closes #1945
Closes #4841
Link to a build that showcases this PR:
https://pobb.in/jJf-KmAMp90k
Screenshot