Skip to content

Conversation

@talkmill
Copy link
Contributor

@talkmill talkmill commented Aug 7, 2022

Fixes #4691 and #1265 .

Description of the problem being solved:

The bottom toolbar in the Tree tab does not always wrap to two lines at the right time.
Problem in #4691 was caused by the fact that the node power selector/button could be shown even if "Show node power" was not selected:
image

but in the logic for wrapping, it was assumed that these two items where hidden.
This was caused by the fact that during initial load, the two items does not check if show node power is selected (this check is only when the box is clicked).

I added logic in the draw-function to make sure that the visibility was set correctly. I also changed the if-statement for wrapping since it did take into account "Node Power", but not take into account if "Compare" is clicked or not.

Steps taken to verify a working solution:

Load PoB both with or without "Show Node Power" selected in the build.
With node power preselected:
image

Without node power preselected
image

Tried the wrapping with the different combinations of node power and Compare to see that it now wraps in the same spot.

@QuickStick123 QuickStick123 added the bug Something isn't working label Aug 7, 2022
@Wires77 Wires77 added user-interface Changes that only affect the UI and removed bug Something isn't working labels Aug 8, 2022
@Wires77 Wires77 merged commit 97effc2 into PathOfBuildingCommunity:dev Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom bar doesn't wrap correctly

3 participants