Skip to content

Conversation

@LocalIdentity
Copy link
Contributor

@LocalIdentity LocalIdentity commented Jul 26, 2022

The PR changes the way veiled mods are chosen for auto-generated uniques. Also adds support for an additional weapon type to fix Cane of Kulemak missing some mods

Remove Master specific mods from Paradoxica that are no longer possible to roll

(Prefix) Always Hits
(Prefix) Bleed On Hit Gained
(Prefix) Cold Added As Chaos
(Prefix) Fire Added As Chaos
(Prefix) Lightning Added As Chaos
(Prefix) Physical Added As Chaos

The mod pool for Kane of Kulemak contained many 1 handed mods and master specific mods that were not possible to roll

(Prefix) Always Hits
(Prefix) Chaos Damage And Chaos Skill Duration
(Prefix) Cold Damage And Base Chance To Freeze
(Prefix) Fire Damage And Chance To Ignite
(Prefix) Lightning Damage And Chance To Shock
(Prefix) Minion Damage And Minion Maximum Life
(Prefix) Socketed Gem Quality
(Prefix) Spell Damage And Mana Regeneration Rate
(Prefix) Spell Damage And Non-Chaos Damage To Add As Chaos Damage
(Suffix) Chaos Damage Over Time Multiplier
(Suffix) Cold Damage Over Time Multiplier
(Suffix) Fire Damage Over Time Multiplier
(Suffix) Minion Attack And Cast Speed On Weapon
(Suffix) Physical Damage Over Time Multiplier

It was also missing some mods that exist on two-handed weapons

(Suffix) Attack Speed Percent If Rare Or Unique Enemy Nearby
(Suffix) Chance To Deal Double Damage While Focused
(Suffix) Critical Strike Multiplier If Rare Or Unique Enemy Nearby
(Suffix) Damage Per Endurance Charge
(Suffix) Damage Per Frenzy Charge
(Suffix) Damage Per Power Charge
(Suffix) Double Damage Chance

The mod pool for both Paradoxica variants contained mods that are no longer possible to contain
The mod pool for Kane of Kulemak contained many 1 handed mods and master specific mods that were not possible to roll
@LocalIdentity LocalIdentity added the bug: accuracy Wording differences label Jul 26, 2022
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably use more than just two specific types for future-proofing, but I'm okay with this until that day comes

@Wires77 Wires77 merged commit 5f962cb into dev Aug 7, 2022
@Wires77 Wires77 deleted the fix_veiled-uniques branch August 7, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: accuracy Wording differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants