Skip to content

Conversation

@Wires77
Copy link
Member

@Wires77 Wires77 commented Jul 25, 2022

Description of the problem being solved:

  • Scorching Ray didn't have an option to only stack to the maximum you could, like Blight. Also removed some dead code.
  • Frost Shield and Sigil of Power didn't get their stage maximum from the skill, so the code was fixed for future proofing. Incidentally, this also added support for anomalous Sigil of Power.
  • The description for Frost Shield and other skills were using the wrong rounding value, so even if the value was correct, the gem description wasn't
  • Removed dead config code for an old Frostbolt alternate quality

Link to a build that showcases this PR:

eNrFG11z2rj2ufsrPLwnBAhptkN2hwBJmAkNF9L23qeOsA-gjWxRW07C_vo9kmxwiGVkZWduHlpjne8vnSPbvT9fQ-Y9Q5xQHl01WqdnDQ8inwc0Wl01vj3enFw2_vzjt96UiPXD8jqlTK788dunnrr2GDwDQ7yGJ0i8AvE9p9T5iZQ2JBJr4NGE_MXjWx5cNb7yCBregkQBFfkvn5Ek-UpCuGrMfURueCTxIQoG-_saMCQ0mnP_CcRtzNMNMml4zxReJjxAmPFk-jB7LDClUZEpyvypN2VkC_FcEOEl-M9Vo4-qkxXcUYGkCEuRzlmjWQ473wAEO7BzE9g0htFyCb6gzzCIqRisSeTDDq912m2bUB3AJykTdMMoxEUUE8YjF4QNp_PjympIvjdL-_Nl97TVyf9MeD-oWCNakUcNzGuGJraST0KPVxEVYA0-5TThUS3tHdQYpIxhilixGfBwQaO3GluymZCIDHiy94_R5_d0CW8gjeKM5nZwM8wYO0gp5RRizGZhhyCFrYWQcZiDz7Fi1OFRB6WghxszB8zR3AXBgdFc7GtH2wg1hFcLqBn8KgJeXJoAx5GwI1cEbHW7ZvGeuVCbh1Vuj-6me6pmKafrbUJ9wibklYZpiNvEI3mCqCBQheNXaxFhJTDh_t45_WxU54bG4IQ44CxwQ1wTnjhhyhDfe7xq-_S_SNhx5NvlzbcohgTi58Kue1GJMMOolxv6goElxp5Fljt7154dYbWCyE6NewB_fYu9y4wIsKs1-6pebU4Ja2VOCVhizq4lQg3jSMQD45z-XgVc0zw_SBxY1MII4tV2vqbAakJnMbQdkI1VS-h_KWJbOeMtu6KpTj53rLBq2mz0TJJibWxdVCukwe0CC7BlQ4QADhrXM3N_zP-S3TGrh9aPQ57Gli7RwFYK5CV-SEJsa2YQpL7dPnLNcBSxlR6lYqwWRl8I4j8NebCCWkzqY8zTzQYTXbrcFk9uTzNIaKG9OLmwgH7AzLJKLLmN2TPYQ1sz2G3P9lwOUOx1kTtrDWX24NYsdgPnBGtXiJVazao4F-9T3ugcnFeshpUpf0Fp1nLMT-pBY1exQzAONDcxRH9vrem_AbdiMIqCNJbhbc3jEKOMzSMNsQImyZAI4iVAYn99j567aqj1XlMdk8ircbjhsVA3B4T5icIeR5tUeJE64whp4v9cpMulPM5ooAixOoMZ3dyMBo_j76OMYREleaKM_YzScCHHf_3_3tVzUJXMS9JFoi-vGt8pvMwl1hAEoQyN4HPGyCaB4KqxJCxBzhQvFcwcNfNFBTUFhc2irp0mWnsAM6XRK8QC9cXd3Y8pGOXarR8RSjOUG7l0kImaPN8wE9IVeEASoXdZg6XUqZCZijykMaojFytwMWYIM3LOVo9YQmw3kOCeSJfUl7Fd7fJHhNZQFXbxfUwLf1vh72wfMdNQBz0mAnrRjKwPckzY2WqFVdWxkdGqetWMPgSfGHXXi2bkXePGI3XmWE5lB1VB6SuPVJBj0vQpkzXf6NkRgx2ImeCDWEOsNxIjpQnWqBykMnFiukiFOY0LEBW2UnOlwUJyzYyqZyiDDnKtohK9mRwMBi3CmEnpUcVYyKpQ827XYD69WqFE3vAb5M-WzQR0_2H0X9bNVOU3trrm_JaLZmSdH-9JiDi1pKBieQhLwCpUGcw7mIp8V1tJ_5nTQDfHH6KmJCsntlevFi2d2aXK1qaohocPang4U_wr5s-OowxFtwByhBBWy7uK_diO0q7bvgPC5HMFzj5G8N2x24f05CIhUTCUBwvWivaaeVPaU31A4iXYrd5CmFxvcTq4kZXu4HlFSARuUhDey0eAj1z2yMQXEN_rR4IZM6IMlbWTQj0pfEM5D9IAliRl8v5_UsKo2Mq-vHA3oxpRNHWy5i8ywDQd2bIkWBPv7_VKn4mMhGSSC6LNlYmhTNBS97Kb6tlify-rsoaSlkY-SwMYR9mglMnAyELKI5-WyuPGXbId0Nmx-dRDaTLgW8YXhLVzlOwZavus8Wa9la-rLn8cyJmHJ0Iu4s1fWsWx6jmUkTLAKYm1mVcQytUJNvoBDifNsUBzNKVNmko0vFIE863uV8HuB0rtCO_N4vM00nzkKCIPXTL5vOK2iHGleB23tDLqR20toY9ZW-kyoRHmyoGnrf0woLHP4GGpZtz3FBWxgn8wICGOcISwc8qcrijbEd95pf3eLWU-UNgeX3rvhcPFNAw55u_Yh1vOIPy_OKll5yKcQuRTRqXhZZ0koTFcAwmPpkjbLkUOyZXlR6kjfB77a9xvvFk-ERQNnV1iMVLVVxddefkYA-RVUxFqZbULfxRfjJCCn0nzJhhd26wpl_aPeCDrYffystNpeALJFV7KaF1m71todC3Vt9m9dslaiE3ypdl8eXk53RCx5kt4pQxOfR42N4iEMp0oC55Iss0-_l2v-upPq5dT6unXNJJmpirKrtSUysmLrxxbf7kmb-Y_lOrygCI7R5mLWOrzN-fh_5SusrrjlismZJMFnVzLdoZOti_g8DqkaI1YNRa5hyTgf_Ojnp7yc2ZkeZ3vTGkC-sHpDyAbzGZ5O68pvQzQCPR2U2E8P6TRYF5r_kI2Xn-xTRLCPG0fr4tYQgfhWR4jJaiHaG07tGqoa46NgqNAZbocEeoamKiJcoOB-uR1rERql4nUcTOvnRHa_xLauZuQF27cLtyt6RJPRzxwBzi8iLqMSiLpwoXPkfDDHeZZDlT1CXfcs6jlwu_cLRZabpF3ftw9NoatS7YsvBwVt6o7XQd5HGpg5xibYOvp856a7iu3slN8dV2QrFLSxhFOenadzdp28PuFWyZ13MK3Uz_Kzt3LvkNMt5yN37EJiHMbIAexP9D8WHrS3QsXDlHp7oYPhIttSZa4llljD-pguZkc0douJabtbF7HcmHvTxd1OhZ2arm74dzZWl0XbWzyxT3Ij4jUD1NWsrf1mtkMqWZhNYSq1wF4tKSrdw_3l_vDOXUWkuyf8J-XvAtw-NnD_g0C9flDycsDhXOmQwadKgbZxxxHGeivPErBpoz4sOYsgDgDhgjCbfaFRS7F5-JbhmXw8vF5_u7BTnQLnPw1pxynm5-BZ57oNQ-_d_kHTehZbg==

Before screenshot:

Frost shield with incorrect +flat crit
image
image
image

After screenshot:

image
image
image

@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Jul 25, 2022
@Nostrademous
Copy link
Contributor

LGTM

@Wires77
Copy link
Member Author

Wires77 commented Aug 7, 2022

Superset of the changes from #4632 @talkmill remind me if our script doesn't automatically include you in the patchnotes for this one.

@Wires77 Wires77 merged commit f6b00ce into PathOfBuildingCommunity:dev Aug 7, 2022
@miaoles
Copy link

miaoles commented Aug 11, 2022

Scorching Ray stacks don't each have their own duration like Blight. The stacks simply increase up to the maximum whilst the beam remains touching. The skill's base duration is only for the lingering effect applied when the beam stops touching the enemy.

@Wires77 Wires77 deleted the fix_buff_stages branch February 8, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants