Skip to content

Conversation

@QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Jul 23, 2022

Fixes #4240.

Description of the problem being solved:

The calculations for armour mitigations are very vague/confusing and have minimal breakdowns.
Spell suppression isn't included if it is guaranteed against spells.
Certain breakdown sections don't hide when irrelevant.
Generalised and separate resistances and base damage reduction. This makes it much easier to handle large changes to this in the future and allowed explicit references to damage types to be removed.

Before Transcendence Armour Stacker

image
image
image
image
image

After

image
image
image
image
image

Before Regular Build

image
image

After

image
image

Before Enduring Cry Transcendence Without

image
image

After

image
image

Before Enduring Cry Transcendence With

image

After

image

With 100% chance spell suppresion will appear in breakdown and get removed from other eHP calculations.

Spell Suppression "Spell"

image

Spell Suppression "Average"

image

Link to a build that showcases this PR:

Transcendence Armour Stacker + Phys to ele https://pobb.in/S8lGNPQF8Af8
Regular Build https://pobb.in/3XXONK_WLL2U
Enduring cry transcendence https://pobb.in/h5VqofF3ymJH

@QuickStick123 QuickStick123 added enhancement New feature, calculation, or mod user-interface Changes that only affect the UI labels Jul 23, 2022
@QuickStick123 QuickStick123 force-pushed the improve-mitagation-calculation-display- branch from b82c595 to 473345f Compare July 27, 2022 10:29
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of minor improvements, but this definitely looks a lot clearer. One thing that is outside of scope for this PR, but we'll eventually want to fix is that armour reductions should only be applying to attacks, not spells.

@Wires77 Wires77 merged commit beede31 into PathOfBuildingCommunity:dev Aug 8, 2022
@QuickStick123 QuickStick123 deleted the improve-mitagation-calculation-display- branch September 15, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PoB should account for spell suppression in "Maximum Hit Taken" if suppression chance is 100%

3 participants