-
Notifications
You must be signed in to change notification settings - Fork 2.2k
General improvements to "Damaging Hits" section and armour breakdown. #4637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Wires77
merged 12 commits into
PathOfBuildingCommunity:dev
from
QuickStick123:improve-mitagation-calculation-display-
Aug 8, 2022
Merged
General improvements to "Damaging Hits" section and armour breakdown. #4637
Wires77
merged 12 commits into
PathOfBuildingCommunity:dev
from
QuickStick123:improve-mitagation-calculation-display-
Aug 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightblade
reviewed
Jul 27, 2022
b82c595 to
473345f
Compare
d911c14 to
df5616b
Compare
Wires77
requested changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of minor improvements, but this definitely looks a lot clearer. One thing that is outside of scope for this PR, but we'll eventually want to fix is that armour reductions should only be applying to attacks, not spells.
Wires77
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4240.
Description of the problem being solved:
The calculations for armour mitigations are very vague/confusing and have minimal breakdowns.
Spell suppression isn't included if it is guaranteed against spells.
Certain breakdown sections don't hide when irrelevant.
Generalised and separate resistances and base damage reduction. This makes it much easier to handle large changes to this in the future and allowed explicit references to damage types to be removed.
Before Transcendence Armour Stacker
After
Before Regular Build
After
Before Enduring Cry Transcendence Without
After
Before Enduring Cry Transcendence With
After
With 100% chance spell suppresion will appear in breakdown and get removed from other eHP calculations.
Spell Suppression "Spell"
Spell Suppression "Average"
Link to a build that showcases this PR:
Transcendence Armour Stacker + Phys to ele https://pobb.in/S8lGNPQF8Af8
Regular Build https://pobb.in/3XXONK_WLL2U
Enduring cry transcendence https://pobb.in/h5VqofF3ymJH