Skip to content

Conversation

@talkmill
Copy link
Contributor

Fixes #4517 .

Description of the problem being solved:

When hovering over the expanded alternate quality box there is a tooltip describing the effect of the quality when hovering with the mouse. When hovering over the "closed" box, there is no tooltip.

Steps taken to verify a working solution:

I removed the if-statement
Modified the tooltipFunc in the qualityID to display the selected item if the listbox is closed.

Link to a build that showcases this PR:

https://pobb.in/ivbVY__36yk8

Before screenshot:

image

After screenshot:

image

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jul 22, 2022
@talkmill talkmill marked this pull request as ready for review July 22, 2022 13:44
@talkmill
Copy link
Contributor Author

I added a small change in how the gemselectcontrol works.

When doing the following:
Clicking the gem select listbox to show all skills, then
pressing enter or left click to get the new skill selected.

The previous behaviour was that the listbox was closed, the text of the new skill written in the Gem Select box, but not with color but rather in edit mode (with cursor in the text box)

With the change, instead of having a cursor in the text box, the skill gets chosen right away when the gem is switched and the gem select box deselected.

@talkmill
Copy link
Contributor Author

talkmill commented Jul 28, 2022

Removed the calls to UpdateGem on focusLost as well as pressing Escape on the skillstab since it is counter intuitive that clicking away and/or pressing escape actually changes anything

@talkmill talkmill changed the title Display effect of active gem variant when mousing over the "Variant" drop-down selector Display effect of active gem variant when mousing over the "Variant" drop-down selector and small behaviour change to gemSelectControl Jul 28, 2022
@talkmill
Copy link
Contributor Author

Fixes #863

@Wires77 Wires77 added user-interface Changes that only affect the UI and removed enhancement New feature, calculation, or mod labels Aug 8, 2022
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but introduces a new behavior where if you click a slot that already has a gem in it, select a gem, then it automatically opens the next slot. Since it's not a bad change, and potentially a desirable one, I'll approve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skills: Display effect of active gem variant when mousing over the "Variant" drop-down selector

3 participants