Fix config tab being 1 change behind enemy level #4624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightblade
reviewed
Jul 20, 2022
src/Classes/ConfigTab.lua
Outdated
| self.enemyModList = enemyModList | ||
| local input = self.input | ||
| local placeholder = self.placeholder | ||
| --enemy level handeled here becouse its needed to correctly set boss stats |
There was a problem hiding this comment.
--enemy level handled here because it's needed to correctly set boss stats
(fixed spelling)
2 tasks
Regisle
force-pushed
the
fixConfigTabWrongEnemyLevel
branch
from
db79d10 to
ec9354d
Compare
LocalIdentity
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where when changing the enemy level in the config tab (or by changing boss preset) it would use the old value, this is because enemy level was calculated after config tab had "rebuilt"
This still needs to rebuild configTab whenever the player level is changed to be fully correct, but is progress