Timeless jewel search improvements #4622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various changes and UI rework
Add minimum weight UI, process fallback node weights, fix total stat tooltips
|
In my opinion devotion notables shouldn't show, these were added back into the list here |
Various requested Timeless Jewel Search Improvements
Swap slider scroll wheel direction + add keyboard arrow support
Round weight output to editbox controls
Fix trailing newline in fallback weights not being culled
LocalIdentity
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #4566, mainly to isolate generator function, as we are unsure how we want to handle power per point and other filter types
This allows you to automatically generate weights for a build based on the change of the stat filter
This also lumps all str/dex/devotion together for their respective jewels, allowing you to search for totals
And adds "minimumWeight" allowing you to specify a minimum must be reached (eg to hit 150 devotion)