Fix "NaN" EHP initialization error and cap enemyLevel #4591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applied characterLevel cap to standard bosses as well, per @Regisle 's feedback. |
LocalIdentity
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4571. Supersedes #4585.
Description of the problem being solved:
Character EHP was
nanfor all new builds, as various different configuration options were not initialized correctly until after you poke some settings in the configuration tab.This also caps enemyLevel to characterLevel for normal enemies when left at their default placeholder level. This does not affect boss enemies, as capping their level doesn't really make sense.
Before screenshots:
After screenshots: