Skip to content

Conversation

@Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Jul 13, 2022

Under certain conditions PoB is denied write access to GetScriptPath(). This generally means the user updates PoB using something other than our built-in updater. In this scenario we cannot write the *.bin TimelessJewelData files to disk, and if we try to do so it breaks quite horribly. Luckily we don't actually need to write those files to disk, so we can just skip it.

See: https://aur.archlinux.org/packages/path-of-building-community-git#comment-873655

Additionally changelog.txt sometimes does not exist. If we attempt to read from it with io.lines before verifying the file actually exists, an error is thrown.

See: https://aur.archlinux.org/packages/path-of-building-community-git#comment-868605

@Lothrik Lothrik added the crash Causes PoB to crash and is High Priority label Jul 13, 2022
@zao
Copy link
Contributor

zao commented Jul 14, 2022

I've tested this PR as of 25506a4 on the AUR version of PoB Community by adding a patch file to a checkout of the PKGBUILD.

Prior to the PR I could reproduce the timeless jewel error mentioned in the AUR comments.
After applying the PR patch the problem was gone and timeless jewels in the tree and the jewel finder works as expected.

The problem with changelog.txt I had no natural way to test but it properly shows an empty About box now if the file is artificially removed from the installation directory.

LGTM!

@LocalIdentity LocalIdentity merged commit abb245d into PathOfBuildingCommunity:dev Jul 15, 2022
@Lothrik Lothrik deleted the skip-writing-uncompressedfile-on-write-deny branch July 15, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Causes PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants