Skip writing uncompressedFile if denied access, and skip reading changelog.txt if it doesn't exist #4588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions PoB is denied write access to
GetScriptPath(). This generally means the user updates PoB using something other than our built-in updater. In this scenario we cannot write the*.binTimelessJewelData files to disk, and if we try to do so it breaks quite horribly. Luckily we don't actually need to write those files to disk, so we can just skip it.See: https://aur.archlinux.org/packages/path-of-building-community-git#comment-873655
Additionally
changelog.txtsometimes does not exist. If we attempt to read from it withio.linesbefore verifying the file actually exists, an error is thrown.See: https://aur.archlinux.org/packages/path-of-building-community-git#comment-868605