Fix auras disabling due to multiple iterations of reservation calculations #4581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jul 13, 2022
2 tasks
QuickStick123
deleted the
Reset-Reservation-Calculations-to-zero-at-start-of-calculations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Auras disable sometimes due to multiple iterations of reservation calculations
As reserve base is calculated with reference to the previous reserve base calculation it grows until the aura gets disabled. This changes it to use the currently calculated flat resource to reserve.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/yyfVaqMYkCpz
Before screenshot:
After screenshot: